Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1549554
| From | Baolin Wang <baolin.wang@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command |
| Date | 2017-01-03 07:30 +0100 |
| Message-ID | <sVqLD-2cs-7@gated-at.bofh.it> (permalink) |
| References | (13 earlier) <sQumR-7fK-1@gated-at.bofh.it> <sQEPf-5GI-9@gated-at.bofh.it> <sQOOD-3SW-55@gated-at.bofh.it> <sSQjf-4Vj-1@gated-at.bofh.it> <sVcfD-8dX-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2 January 2017 at 22:57, Mathias Nyman <mathias.nyman@linux.intel.com> wrote: > On 27.12.2016 05:07, Baolin Wang wrote: >> >> Hi, >> >> On 21 December 2016 at 21:00, Mathias Nyman >> <mathias.nyman@linux.intel.com> wrote: >>> >>> On 21.12.2016 04:22, Baolin Wang wrote: >>>> >>>> >>>> Hi Mathias, >>>> >>>> On 20 December 2016 at 23:13, Mathias Nyman >>>> <mathias.nyman@linux.intel.com> wrote: >>>>> >>>>> >>>>> On 20.12.2016 09:30, Baolin Wang wrote: >>>>> ... >>>>> >>>>> Alright, I gathered all current work related to xhci races and timeouts >>>>> and put them into a branch: >>>>> >>>>> git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git >>>>> timeout_race_fixes >>>>> >>>>> Its based on 4.9 >>>>> It includes a few other patches just to avoid conflicts and make my >>>>> life >>>>> easier >>>>> >>>>> Interesting patches are: >>>>> >>>>> ee4eb91 xhci: remove unnecessary check for pending timer >>>>> 0cba67d xhci: detect stop endpoint race using pending timer instead of >>>>> counter. >>>>> 4f2535f xhci: Handle command completion and timeout race >>>>> b9d00d7 usb: host: xhci: Fix possible wild pointer when handling abort >>>>> command >>>>> 529a5a0 usb: xhci: fix possible wild pointer >>>>> 4766555 xhci: Fix race related to abort operation >>>>> de834a3 xhci: Use delayed_work instead of timer for command timeout >>>>> 69973b8 Linux 4.9 >>>>> >>>>> The fixes for command queue races will go to usb-linus and stable, the >>>>> reworks for stop ep watchdog timer will go to usb-next. >>>> >>>> >>>> >>>> How about applying below patch in your 'timeout_race_fixes' branch? >>>> [PATCH] usb: host: xhci: Clean up commands when stop endpoint command is >>>> timeout >>>> https://lkml.org/lkml/2016/12/13/94 >>>> >>> >>> usb_hc_died() should eventyally end up calling xhci_mem_cleanup() >>> which will cleanup the command queue. But I need to look into that >> >> >> usb_hc_died() did not call xhci_mem_cleanup() to clean up command >> queue, it just disconnects all children devices attached on the dying >> hub. I did not find where it will clean up the command queue when >> issuing usb_hc_died(). Also before issuing usb_hc_died() in >> xhci_handle_command_timeout(), we will call >> xhci_cleanup_command_queue(). I think it should same as in >> xhci_stop_endpoint_command_watchdog(). >> > > You're right, it doesn't call xhci_mem_cleanup. > Need to look at this after getting first series of fixes to usb-linus Thanks. -- Baolin.wang Best Regards
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-12-12 17:00 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Baolin Wang <baolin.wang@linaro.org> - 2016-12-13 04:30 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-12-19 11:40 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Baolin Wang <baolin.wang@linaro.org> - 2016-12-19 12:40 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Mathias Nyman <mathias.nyman@intel.com> - 2016-12-19 13:20 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Baolin Wang <baolin.wang@linaro.org> - 2016-12-20 04:30 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Lu Baolu <baolu.lu@linux.intel.com> - 2016-12-20 05:30 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Baolin Wang <baolin.wang@linaro.org> - 2016-12-20 07:10 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Lu Baolu <baolu.lu@linux.intel.com> - 2016-12-20 07:50 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Baolin Wang <baolin.wang@linaro.org> - 2016-12-20 07:50 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Lu Baolu <baolu.lu@linux.intel.com> - 2016-12-20 08:20 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Baolin Wang <baolin.wang@linaro.org> - 2016-12-20 08:40 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-12-20 16:20 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Baolin Wang <baolin.wang@linaro.org> - 2016-12-21 03:30 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-12-21 14:10 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Baolin Wang <baolin.wang@linaro.org> - 2016-12-27 04:10 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Mathias Nyman <mathias.nyman@linux.intel.com> - 2017-01-02 16:00 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Baolin Wang <baolin.wang@linaro.org> - 2017-01-03 07:30 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Lu Baolu <baolu.lu@linux.intel.com> - 2016-12-21 07:20 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-12-21 13:50 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - 2016-12-21 15:40 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-12-21 16:10 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - 2016-12-21 16:20 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Lu Baolu <baolu.lu@linux.intel.com> - 2016-12-22 02:50 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-12-23 14:00 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Lu Baolu <baolu.lu@linux.intel.com> - 2016-12-22 02:50 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Lu Baolu <baolu.lu@linux.intel.com> - 2016-12-21 08:00 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-12-21 14:00 +0100
Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command Lu Baolu <baolu.lu@linux.intel.com> - 2016-12-22 02:50 +0100
csiph-web