Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1549341

Re: [PATCH] hwmon: (lm90) fix temp1_max_alarm attribute

Show all headers | View raw

On 01/02/2017 08:53 AM, Michael Walle wrote:
> Since commit commit eb1c8f4325d5 ("hwmon: (lm90) Convert to use new hwmon
> registration API") the temp1_max_alarm and temp1_crit_alarm attributes are
> mapped to the same alarm bit. Fix the typo.
>
> Fixes: eb1c8f4325d5 ("hwmon: (lm90) Convert to use new hwmon registration API")
> Signed-off-by: Micehael Walle <michael@walle.cc>

Good catch. Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/lm90.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
> index 322ed92..841f242 100644
> --- a/drivers/hwmon/lm90.c
> +++ b/drivers/hwmon/lm90.c
> @@ -1036,7 +1036,7 @@ static const u8 lm90_temp_emerg_index[3] = {
>  };
>
>  static const u8 lm90_min_alarm_bits[3] = { 5, 3, 11 };
> -static const u8 lm90_max_alarm_bits[3] = { 0, 4, 12 };
> +static const u8 lm90_max_alarm_bits[3] = { 6, 4, 12 };
>  static const u8 lm90_crit_alarm_bits[3] = { 0, 1, 9 };
>  static const u8 lm90_emergency_alarm_bits[3] = { 15, 13, 14 };
>  static const u8 lm90_fault_bits[3] = { 0, 2, 10 };
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] hwmon: (lm90) fix temp1_max_alarm attribute Michael Walle <michael@walle.cc> - 2017-01-02 18:00 +0100
  Re: [PATCH] hwmon: (lm90) fix temp1_max_alarm attribute Guenter Roeck <linux@roeck-us.net> - 2017-01-02 19:20 +0100

csiph-web