Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1549334

Re: [PATCH 2/9] ARM: dts: omap3: Add an empty chosen node to top level DTSI

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Pali Rohár <pali.rohar@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/9] ARM: dts: omap3: Add an empty chosen node to top level DTSI
Date Mon, 02 Jan 2017 19:10:01 +0100
Message-ID <sVfdv-2gm-3@gated-at.bofh.it> (permalink)
References <sQ7qh-Il-1@gated-at.bofh.it> <sQ7qh-Il-23@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-transfer-encoding:message-id; bh=eHte4yF1+Ic4jgI51e+I4hV08oURa+KaKRnsBd7aRaU=; b=akW3qLB0AX+6mMXvGMnNENTqKvnUQemsVzyGZfKkxXcyxGhkI/LhPxGjqZTPKA+eyl GzFJb0tevpz7Giqw19LhDLX1/eWaz4YrQGins1EO7ol9EZypUdsW78vxP8oDW2fUvMJD joP3jH/7Up/ZUB3lfI1QtMYTujobUGxQmmy1eUWS+EFI74iIUngKRpH7K/HhjtwXsjRY U7Yk41NHzfOfzoZ7qO82DgDoZcOIjqeHFxselbXSRFex8Awit4EIypGSgCJiPjJ9JUhc jRXl41UBLwDdj9+iJo9U12K6/1y30BeoDjHkzSanf9xOFJu+R2rq+X/7gs0AcE2Kftxl tQmw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-transfer-encoding:message-id; bh=eHte4yF1+Ic4jgI51e+I4hV08oURa+KaKRnsBd7aRaU=; b=SNj65MnsQ9zd/1btBwl0DKDz4hqeD0Q/eVtek1XOrFcVCBZ15yH/Do+uuGgTWZqp53 31CS+P7AH0+JwlMSLRQ2gvCgg7aj6NQyBaMkc/03v2YgY1qA+8SfzkCZKG2mm91p5pbX H5k5sRINOkReeG7CYhlIQ0z3+nXwQ/tO25tERwwnHuiB6ZOTjENiw2mptmvPpmcl+05V D7ri/pBk7bgxkLqJxxcAQSiVI3xICAB03BJ7Lk2kSY65QvoKlVta+gEfq9MAgv7QoS6h VcChjwAsXaqndBQtsuPeNkOPMezhkVQAT88W5c9QBY7epHo4mMeVYOQxs4JM+Tf/Z0Ba Pliw==
X-Gm-Message-State AIkVDXIt8T8WwChZL6P93OrsZ8vGzp7n3TqdygPjtzlK8lU6hXQIexvv5TqMrlzbPi6cLQ==
X-Received by 10.194.242.101 with SMTP id wp5mr50599577wjc.11.1483380084346; Mon, 02 Jan 2017 10:01:24 -0800 (PST)
User-Agent KMail/1.13.7 (Linux/4.9.0-040900-generic; KDE/4.14.2; x86_64; ; )
MIME-Version 1.0
Content-Type multipart/signed; boundary="nextPart1589658.ne9uvhShho"; protocol="application/pgp-signature"; micalg=pgp-sha1
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 38
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org, Benoît Cousson <bcousson@baylibre.com>, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Tony Lindgren <tony@atomide.com>, Mark Rutland <mark.rutland@arm.com>, linux-omap@vger.kernel.org, Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org
X-Original-Date Mon, 2 Jan 2017 19:01:22 +0100
X-Original-Message-ID <201701021901.22476@pali>
X-Original-References <1482158681-4530-1-git-send-email-javier@osg.samsung.com> <1482158681-4530-3-git-send-email-javier@osg.samsung.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1549334

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Monday 19 December 2016 15:44:34 Javier Martinez Canillas wrote:
> Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage")
> removed the skeleton.dtsi usage since we want to get rid of it.
> 
> But this can cause issues when booting a kernel with a boot-loader
> that doesn't create a chosen node if this isn't present in the DTB
> since the decompressor relies on a pre-existing chosen node to be
> available to insert the command line and merge other ATAGS info.
> 
> Fixes: 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage")
> Reported-by: Pali Rohar <pali.rohar@gmail.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Including empty chosen node fixes (or rather workaround) this problem. 
You can add my Tested-By.

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/9] ARM: omap: Add empty chosen node in SoCs top level DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-19 15:50 +0100
  [PATCH 3/9] ARM: dts: omap4: Add an empty chosen node to top level DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-19 15:50 +0100
  [PATCH 2/9] ARM: dts: omap3: Add an empty chosen node to top level DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-19 15:50 +0100
    Re: [PATCH 2/9] ARM: dts: omap3: Add an empty chosen node to top level DTSI Pali Rohár <pali.rohar@gmail.com> - 2017-01-02 19:10 +0100
  [PATCH 5/9] ARM: dts: am33xx: Add an empty chosen node to top level DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-19 15:50 +0100
  [PATCH 1/9] ARM: dts: omap2: Add an empty chosen node to top level DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-19 15:50 +0100
  [PATCH 4/9] ARM: dts: omap5: Add an empty chosen node to top level DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-19 15:50 +0100
  [PATCH 6/9] ARM: dts: am4372: Add an empty chosen node to top level DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-19 15:50 +0100
  [PATCH 7/9] ARM: dts: dm814x: Add an empty chosen node to top level DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-19 15:50 +0100
  [PATCH 9/9] ARM: dts: dra7: Add an empty chosen node to top level DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-19 16:00 +0100
  [PATCH 8/9] ARM: dts: dm816x: Add an empty chosen node to top level DTSI Javier Martinez Canillas <javier@osg.samsung.com> - 2016-12-19 16:00 +0100
  Re: [PATCH 0/9] ARM: omap: Add empty chosen node in SoCs top level  DTSI Tony Lindgren <tony@atomide.com> - 2016-12-27 18:40 +0100

csiph-web