Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1549338

[PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject [PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table
Date Mon, 02 Jan 2017 19:10:01 +0100
Message-ID <sVfdv-2gm-17@gated-at.bofh.it> (permalink)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 29
Organization linux.* mail to news gateway
X-Original-Cc Javier Martinez Canillas <javier@osg.samsung.com>, Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>, Paul Burton <paul.burton@imgtec.com>
X-Original-Date Mon, 2 Jan 2017 15:06:55 -0300
X-Original-Message-ID <1483380416-9153-1-git-send-email-javier@osg.samsung.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1549338

Show key headers only | View raw


The OF device ID table doesn't have a sentinel NULL entry and so it
causes the following error:

FATAL: drivers/auxdisplay/img-ascii-lcd: struct of_device_id is not terminated with a NULL entry!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1493: recipe for target 'modules' failed
make: *** [modules] Error 2

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/auxdisplay/img-ascii-lcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
index bf43b5d2aafc..73bc826144d4 100644
--- a/drivers/auxdisplay/img-ascii-lcd.c
+++ b/drivers/auxdisplay/img-ascii-lcd.c
@@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[] = {
 	{ .compatible = "img,boston-lcd", .data = &boston_config },
 	{ .compatible = "mti,malta-lcd", .data = &malta_config },
 	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
+	{ /* sentinel */ },
 };
 
 /**
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-02 19:10 +0100

csiph-web