Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1549353
| From | Noralf Trønnes <noralf@tronnes.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask |
| Date | 2017-01-02 19:40 +0100 |
| Message-ID | <sVfGx-2tw-7@gated-at.bofh.it> (permalink) |
| References | <sV985-6ct-5@gated-at.bofh.it> <sV986-6ct-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Den 02.01.2017 12:35, skrev Andy Shevchenko:
> Usually it's not consumer's business to override resources passed from
> provider, in particularly DMA coherent mask.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/staging/fbtft/fbtft-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index e8bf0d1ec11f..226be8c09768 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -841,7 +841,6 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
> if (txbuflen > 0) {
> #ifdef CONFIG_HAS_DMA
> if (dma) {
> - dev->coherent_dma_mask = ~0;
Can we make this conditional like in of_dma_configure():
if (!dev->coherent_dma_mask)
dev->coherent_dma_mask = DMA_BIT_MASK(32);
If not, I guess the mask has to be set before adding the spi device in
fbtft_device.c to keep it from breaking.
Noralf.
> txbuf = dmam_alloc_coherent(dev, txbuflen,
> &par->txbuf.dma, GFP_DMA);
> } else
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/6] fbtft: make it work with DMA enabled SPI Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-02 12:40 +0100
[PATCH v2 4/6] staging: fbtft: propagate error code from kstrto*() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-02 12:40 +0100
Re: [PATCH v2 0/6] fbtft: make it work with DMA enabled SPI Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-02 12:40 +0100
Re: [PATCH v2 0/6] fbtft: make it work with DMA enabled SPI Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-03 17:00 +0100
Re: [PATCH v2 0/6] fbtft: make it work with DMA enabled SPI Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-03 17:00 +0100
[PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-02 12:40 +0100
Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask Noralf Trønnes <noralf@tronnes.org> - 2017-01-02 19:40 +0100
Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-03 12:00 +0100
Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-03 15:10 +0100
Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask Noralf Trønnes <noralf@tronnes.org> - 2017-01-03 18:20 +0100
[PATCH v2 6/6] staging: fbtft: fb_ssd1306: Refactor write_vmem() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-02 12:40 +0100
csiph-web