Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF registration

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF registration
Date	2017-01-02 17:40 +0100
Message-ID	<sVdOp-19V-5@gated-at.bofh.it> (permalink)
References	<sVcSl-n5-7@gated-at.bofh.it> <sVdlo-MV-15@gated-at.bofh.it> <sVdv3-YY-7@gated-at.bofh.it> <sVdEJ-16T-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/02/2017 01:24 PM, Arnd Bergmann wrote:
> On Monday, January 2, 2017 1:13:24 PM CET Javier Martinez Canillas wrote:
>> Hello Arnd,
>>
>> On 01/02/2017 01:05 PM, Arnd Bergmann wrote:
>>> On Monday, January 2, 2017 12:38:02 PM CET Javier Martinez Canillas wrote:
>>>> If the driver is built as a module, autoload won't work because the module
>>>> alias information is not filled. So user-space can't match the registered
>>>> device with the corresponding module if the device isn't registered via OF.
>>>>
>>>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>>
>>> I think we can just remove the table, as the platform only supports
>>> booting through DT anyway.
>>>
>>
>> Agreed. I should had checked if mach-picoxcell was DT-only indeed.
>>
>> Should I also make the driver to depend on OF and remove the #ifdefery then?
> 
> I don't think we need a dependency, the #ifdef checks in there were needed
> only to make the driver smaller if OF is disabled and it should still build
> fine if someone tries to compile it for CONFIG_COMPILE_TEST without
> CONFIG_OF.
>

OK, the driver doesn't depend on COMPILE_TEST though but I agree with you
since it seems the driver only has runtime but no build time dependencies
with ARCH_PICOXCELL.
 
> If we remove the platform ID, we can however also remove the 
> spacc_is_compatible() function and just call of_device_is_compatible()
> in its place.
>

Yes.

> 	Arnd
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] crypto: picoxcell - Fix module autoload for non-OF registration Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-02 16:40 +0100
  Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF registration Arnd Bergmann <arnd@arndb.de> - 2017-01-02 17:10 +0100
    Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF  registration Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-02 17:20 +0100
      Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF registration Arnd Bergmann <arnd@arndb.de> - 2017-01-02 17:30 +0100
        Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF  registration Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-02 17:40 +0100

csiph-web