Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1549260

[RFC 3/3] sched: ignore task_h_load for CPU_NEWLY_IDLE

From Uladzislau Rezki <urezki@gmail.com>
Newsgroups linux.kernel
Subject [RFC 3/3] sched: ignore task_h_load for CPU_NEWLY_IDLE
Date 2017-01-02 16:50 +0100
Message-ID <sVd22-r2-11@gated-at.bofh.it> (permalink)
References <sVd22-r2-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Uladzislau 2 Rezki <uladzislau2.rezki@sonymobile.com>

A load balancer calculates imbalance factor for particular shed
domain and tries to steal up the prescribed amount of weighted load.
However, a small imbalance factor would sometimes prevent us from
stealing any tasks at all. When a CPU is newly idle, it should
steal first task which passes a migration criteria.

Signed-off-by: Uladzislau 2 Rezki <uladzislau2.rezki@sonymobile.com>
---
 kernel/sched/fair.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 9ebcab1..00b63cc 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6534,8 +6534,9 @@ static int detach_tasks(struct lb_env *env)
 		if (sched_feat(LB_MIN) && load < 16 && !env->sd->nr_balance_failed)
 			goto next;
 
-		if ((load / 2) > env->imbalance)
-			goto next;
+		if (env->idle != CPU_NEWLY_IDLE)
+			if ((load / 2) > env->imbalance)
+				goto next;
 
 		detach_task(p, env);
 		list_add(&p->se.group_node, &env->tasks);
-- 
2.1.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC 1/3] sched: set loop_max after rq lock is taken Uladzislau Rezki <urezki@gmail.com> - 2017-01-02 16:50 +0100
  [RFC 3/3] sched: ignore task_h_load for CPU_NEWLY_IDLE Uladzislau Rezki <urezki@gmail.com> - 2017-01-02 16:50 +0100
  [RFC 2/3] sched: set number of iterations to h_nr_running Uladzislau Rezki <urezki@gmail.com> - 2017-01-02 16:50 +0100

csiph-web