Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1551020

Re: [Patch v2 2/2] firmware: qcom: scm: Fix interrupted SCM calls

From Will Deacon <will.deacon@arm.com>
Newsgroups linux.kernel
Subject Re: [Patch v2 2/2] firmware: qcom: scm: Fix interrupted SCM calls
Date 2017-01-04 18:40 +0100
Message-ID <sVXHB-7LF-77@gated-at.bofh.it> (permalink)
References <sTSj0-4Jr-5@gated-at.bofh.it> <sTSj0-4Jr-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Dec 29, 2016 at 05:27:26PM -0600, Andy Gross wrote:
> This patch adds a Qualcomm specific quirk to the arm_smccc_smc call.
> 
> On Qualcomm ARM64 platforms, the SMC call can return before it has
> completed.  If this occurs, the call can be restarted, but it requires
> using the returned session ID value from the interrupted SMC call.
> 
> The quirk stores off the session ID from the interrupted call in the
> quirk structure so that it can be used by the caller.
> 
> This patch folds in a fix given by Sricharan R:
> https://lkml.org/lkml/2016/9/28/272
> 
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
> ---
>  arch/arm64/kernel/smccc-call.S |  9 ++++++++-
>  drivers/firmware/qcom_scm-64.c | 13 ++++++++++---
>  include/linux/arm-smccc.h      | 11 ++++++++---
>  3 files changed, 26 insertions(+), 7 deletions(-)

Reviewed-by: Will Deacon <will.deacon@arm.com>

Thanks for sticking with this, it looks good to me now.

Will

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [Patch v2 2/2] firmware: qcom: scm: Fix interrupted SCM calls Will Deacon <will.deacon@arm.com> - 2017-01-04 18:40 +0100

csiph-web