Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1551042

[PATCH v3] tools: perf: fix linker error when libelf config is disabled

Show all headers | View raw

When libelf is disabled in the configuration, we get the following
linker error:
  LINK     libperf-jvmti.so
  ld: cannot find -lelf
  Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed

Jiri pointed out that both librt and libelf are not really required. So
this patch fixes the linker error by getting rid of unwanted libraries
in the linker stage.

Fixes: 209045adc2bb ("perf tools: add JVMTI agent library")
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

v2->v3:
	- Corrected the original commit under "Fixes:" tag that
	  introduced the libraries initially
v1->v2:
	- Dropped libelf and librt as they are not required

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 8fc24824705e..9e4a7ea84637 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -512,7 +512,7 @@ $(LIBJVMTI_IN): FORCE
 	$(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=jvmti obj=jvmti

 $(OUTPUT)$(LIBJVMTI): $(LIBJVMTI_IN)
-	$(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< -lelf -lrt
+	$(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $<
 endif

 $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h)
--
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tools: perf: fix linker error when libelf config is disabled Sudeep Holla <sudeep.holla@arm.com> - 2017-01-04 15:00 +0100
  Re: [PATCH] tools: perf: fix linker error when libelf config is  disabled Jiri Olsa <jolsa@redhat.com> - 2017-01-04 15:50 +0100
    Re: [PATCH] tools: perf: fix linker error when libelf config is  disabled Sudeep Holla <sudeep.holla@arm.com> - 2017-01-04 17:00 +0100
  [PATCH v2] tools: perf: fix linker error when libelf config is disabled Sudeep Holla <sudeep.holla@arm.com> - 2017-01-04 17:00 +0100
    Re: [PATCH v2] tools: perf: fix linker error when libelf config is  disabled Sudeep Holla <sudeep.holla@arm.com> - 2017-01-04 17:10 +0100
      Re: [PATCH v2] tools: perf: fix linker error when libelf config is  disabled Sudeep Holla <sudeep.holla@arm.com> - 2017-01-04 17:20 +0100
        Re: [PATCH v2] tools: perf: fix linker error when libelf config is  disabled Jiri Olsa <jolsa@redhat.com> - 2017-01-04 18:30 +0100
          Re: [PATCH v2] tools: perf: fix linker error when libelf config is  disabled Sudeep Holla <sudeep.holla@arm.com> - 2017-01-04 18:40 +0100
    Re: [PATCH v2] tools: perf: fix linker error when libelf config is  disabled Jiri Olsa <jolsa@redhat.com> - 2017-01-04 17:10 +0100
    Re: [PATCH v3] tools: perf: fix linker error when libelf config is  disabled Jiri Olsa <jolsa@redhat.com> - 2017-01-04 18:40 +0100
    [PATCH v3] tools: perf: fix linker error when libelf config is disabled Sudeep Holla <sudeep.holla@arm.com> - 2017-01-04 19:00 +0100

csiph-web