Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver
Date	Wed, 04 Jan 2017 14:10:02 +0100
Message-ID	<sVTui-55P-53@gated-at.bofh.it> (permalink)
References	<sRmQh-dg-7@gated-at.bofh.it> <sRmQh-dg-15@gated-at.bofh.it> <sVu2S-4qr-27@gated-at.bofh.it> <sVNIe-YZ-3@gated-at.bofh.it> <sVQd3-2M8-13@gated-at.bofh.it>
X-Original-To	Jiri Kosina <jikos@kernel.org>
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-1
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.7.2 (2016-11-26)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	"Xu, Even" <even.xu@intel.com>, "srinivas.pandruvada@linux.intel.com" <srinivas.pandruvada@linux.intel.com>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>, "benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "arnd@arndb.de" <arnd@arndb.de>, "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
X-Original-Date	Wed, 4 Jan 2017 13:59:30 +0100
X-Original-Message-ID	<20170104125930.GA8296@kroah.com>
X-Original-References	<1482456149-4841-1-git-send-email-even.xu@intel.com> <1482456149-4841-7-git-send-email-even.xu@intel.com> <alpine.LSU.2.20.1701031050510.28985@cbobk.fhfr.pm> <1483512029.25176.7.camel@intel.com> <alpine.LSU.2.20.1701041032150.28985@cbobk.fhfr.pm>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1550761

Show key headers only | View raw

On Wed, Jan 04, 2017 at 10:36:18AM +0100, Jiri Kosina wrote:
> On Wed, 4 Jan 2017, Xu, Even wrote:
> 
> > > [ ... snip ... ]
> > > > 
> > > > +static ssize_t ishtp_cl_write(struct file *file, const char __user
> > > > *ubuf,
> > > > +	size_t length, loff_t *offset)
> > > > +{
> > > > +	struct ishtp_cl_miscdev *ishtp_cl_misc = file-
> > > > >private_data;
> > > > +	struct ishtp_cl *cl;
> > > > +	void *write_buf;
> > > > +	struct ishtp_device *dev;
> > > > +	int ret;
> > > > +
> > > > +	/* Non-blocking semantics are not supported */
> > > > +	if (file->f_flags & O_NONBLOCK) {
> > > > +		ret = -EINVAL;
> > > > +		goto out_unlock;
> > > When taking the error path here you'd try to unlock 
> > > ishtp_cl_misc->cl_mutex before actually acquiring it.
> > > 
> > 
> > Thanks for your comments, Jiri, I update my patch below:
> 
> Greg, how would you like to handle this (after you're done with reviewing 
> it of course), given that this driver depends on the preceeding 6 patches 
> to intel-ish-hid driver?

Let me go review it now, but if it's ok, I have no problem taking it in
my tree, or if you want to take it through yours, that's fine with me,
which ever is easiest for you.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients  driver Jiri Kosina <jikos@kernel.org> - 2017-01-04 10:40 +0100
  Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients  driver "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2017-01-04 14:10 +0100

csiph-web