Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550635

Re: [v1] gpu: drm: sti: sti_vtg:- Handle return NULL error from devm_ioremap_nocache

Show all headers | View raw

Thanks for the patch.

Acked-by: Vincent Abriou <vincent.abriou@st.com>

I will take it for pull request that should be issued by the end of the 
week.

Vincent

On 12/21/2016 06:30 AM, Arvind Yadav wrote:
> Here, If devm_ioremap_nocache will fail. It will return NULL.
> Kernel can run into a NULL-pointer dereference. This error check
> will avoid NULL pointer dereference.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/gpu/drm/sti/sti_vtg.c |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
> index a8882bd..c3d9c8a 100644
> --- a/drivers/gpu/drm/sti/sti_vtg.c
> +++ b/drivers/gpu/drm/sti/sti_vtg.c
> @@ -429,6 +429,10 @@ static int vtg_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  	}
>  	vtg->regs = devm_ioremap_nocache(dev, res->start, resource_size(res));
> +	if (!vtg->regs) {
> +		DRM_ERROR("failed to remap I/O memory\n");
> +		return -ENOMEM;
> +	}
>
>  	np = of_parse_phandle(pdev->dev.of_node, "st,slave", 0);
>  	if (np) {
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [v1] gpu: drm: sti: sti_vtg:- Handle return NULL error from  devm_ioremap_nocache Vincent ABRIOU <vincent.abriou@st.com> - 2017-01-04 11:30 +0100

csiph-web