Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550543

Re: [PATCH v5 1/3] drm/exynos: mic: Add mode_set callback function

Show all headers | View raw

On 04.01.2017 09:15, Hoegeun Kwon wrote:
> Before applying the patch, used the of_get_videomode function to
> parse the display-timings in the panel which is the child driver
> of dsi in the devicetree. this is wrong. So removed the
> of_get_videomode and fixed to get videomode struct through
> mode_set callback function.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

Only one, non-blocking comment below.

> ---
>  drivers/gpu/drm/exynos/exynos_drm_mic.c | 30 +++++++++++++++++++-----------
>  1 file changed, 19 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index a0def0b..a0f459c 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -286,13 +286,6 @@ static int parse_dt(struct exynos_mic *mic)
>  			}
>  			nodes[j++] = remote_node;
>  
> -			ret = of_get_videomode(remote_node,
> -							&mic->vm, 0);
> -			if (ret) {
> -				DRM_ERROR("mic: failed to get videomode");
> -				goto exit;
> -			}
> -

I think the whole parse_dt function should be refactored, but it can be
done later in separate patch.

Regards
Andrzej

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 1/3] drm/exynos: mic: Add mode_set callback function Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-01-04 09:20 +0100
  Re: [PATCH v5 1/3] drm/exynos: mic: Add mode_set callback function Andrzej Hajda <a.hajda@samsung.com> - 2017-01-04 10:10 +0100

csiph-web