Re: [tip:timers/urgent] ktime: Get rid of the union

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [tip:timers/urgent] ktime: Get rid of the union
Date	2017-01-04 10:00 +0100
Message-ID	<sVPAl-2hI-15@gated-at.bofh.it> (permalink)
References	<sVuFz-4UG-11@gated-at.bofh.it> <sVuFz-4UG-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 3 Jan 2017, Peter Zijlstra wrote:

> On Sun, Dec 25, 2016 at 05:26:33AM -0800, tip-bot for Thomas Gleixner wrote:
> > Commit-ID:  64dac5c9e0f5a933e4520f0cb689b7b143925207
> > Gitweb:     http://git.kernel.org/tip/64dac5c9e0f5a933e4520f0cb689b7b143925207
> > Author:     Thomas Gleixner <tglx@linutronix.de>
> > AuthorDate: Sun, 25 Dec 2016 11:38:40 +0100
> > Committer:  Thomas Gleixner <tglx@linutronix.de>
> > CommitDate: Sun, 25 Dec 2016 13:11:50 +0100
> > 
> > ktime: Get rid of the union
> > 
> > ktime is a union because the initial implementation stored the time in
> > scalar nanoseconds on 64 bit machine and in a endianess optimized timespec
> > variant for 32bit machines. The Y2038 cleanup removed the timespec variant
> > and switched everything to scalar nanoseconds. The union remained, but
> > become completely pointless.
> > 
> > Get rid of the union and just keep ktime_t as simple typedef of type s64.
> 
> All good stuff. One question that remains is why keep the type while
> removing the cycles_t type?

That would have been a massive surgery which I was not able to pull off on
top of the other changes.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [tip:timers/urgent] ktime: Get rid of the union Thomas Gleixner <tglx@linutronix.de> - 2017-01-04 10:00 +0100
  Re: [tip:timers/urgent] ktime: Get rid of the union Peter Zijlstra <peterz@infradead.org> - 2017-01-04 10:50 +0100
    Re: [tip:timers/urgent] ktime: Get rid of the union Frederic Weisbecker <fweisbec@gmail.com> - 2017-01-04 15:00 +0100

csiph-web