Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550357

Re: [v2 3/7] x86/mpx, x86/insn: Relocate insn util functions to a new insn-utils

Show all headers | View raw

On Tue, 2017-01-03 at 08:44 -0800, Dave Hansen wrote:
> On 12/23/2016 05:37 PM, Ricardo Neri wrote:
> > Other kernel submodules can benefit from using the utility functions
> > defined in mpx.c to obtain the addresses and values of operands contained
> > in the general purpose registers. An instance of this is the emulation code
> > used for instructions protected by the Intel User-Mode Instruction
> > Prevention feature.
> 
> I haven't looked at this in detail, but as long as this is pretty much a
> straight code move, I don't see any issues with it from an MPX
> perspective.  I'm glad to see it getting reused.

Yes, this is only a relocation of code.
> 
> Feel free to add my Acked-by on it if you like.

Great! Thanks!
Ricardo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[v2 0/7] x86: enable User-Mode Instruction Prevention Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2016-12-24 02:40 +0100
  [v2 5/7] x86: Add emulation code for UMIP instructions Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2016-12-24 02:40 +0100
    Re: [v2 5/7] x86: Add emulation code for UMIP instructions Andy Lutomirski <luto@amacapital.net> - 2016-12-24 03:20 +0100
      Re: [v2 5/7] x86: Add emulation code for UMIP instructions Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2016-12-28 01:40 +0100
        Re: [v2 5/7] x86: Add emulation code for UMIP instructions Andy Lutomirski <luto@amacapital.net> - 2016-12-28 01:50 +0100
          Re: [v2 5/7] x86: Add emulation code for UMIP instructions Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2016-12-30 06:30 +0100
            Re: [v2 5/7] x86: Add emulation code for UMIP instructions Andy Lutomirski <luto@amacapital.net> - 2016-12-31 03:10 +0100
              Re: [v2 5/7] x86: Add emulation code for UMIP instructions Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-01-04 02:40 +0100
    Re: [v2 5/7] x86: Add emulation code for UMIP instructions Masami Hiramatsu <mhiramat@kernel.org> - 2016-12-25 17:00 +0100
      Re: [v2 5/7] x86: Add emulation code for UMIP instructions Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2016-12-28 01:50 +0100
  [v2 3/7] x86/mpx, x86/insn: Relocate insn util functions to a new insn-utils Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2016-12-24 02:40 +0100
    Re: [v2 3/7] x86/mpx, x86/insn: Relocate insn util functions to a  new insn-utils kbuild test robot <lkp@intel.com> - 2016-12-24 03:40 +0100
    Re: [v2 3/7] x86/mpx, x86/insn: Relocate insn util functions to a  new insn-utils Masami Hiramatsu <mhiramat@kernel.org> - 2016-12-25 07:20 +0100
      Re: [v2 3/7] x86/mpx, x86/insn: Relocate insn util functions to a  new insn-utils Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2016-12-27 23:40 +0100
    Re: [v2 3/7] x86/mpx, x86/insn: Relocate insn util functions to a new  insn-utils Dave Hansen <dave.hansen@linux.intel.com> - 2017-01-03 17:50 +0100
      Re: [v2 3/7] x86/mpx, x86/insn: Relocate insn util functions to a  new insn-utils Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-01-04 02:40 +0100
  [v2 2/7] x86/mpx: Fail when implicit zero-displacement is used along with R/EBP Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2016-12-24 02:50 +0100
    Re: [v2 2/7] x86/mpx: Fail when implicit zero-displacement is used  along with R/EBP Andy Lutomirski <luto@amacapital.net> - 2016-12-24 03:00 +0100
      Re: [v2 2/7] x86/mpx: Fail when implicit zero-displacement is used  along with R/EBP Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2016-12-27 23:40 +0100
        Re: [v2 2/7] x86/mpx: Fail when implicit zero-displacement is used  along with R/EBP Dave Hansen <dave.hansen@linux.intel.com> - 2017-01-03 17:50 +0100
          Re: [v2 2/7] x86/mpx: Fail when implicit zero-displacement is used  along with R/EBP Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-01-04 02:40 +0100

csiph-web