Re: [PATCH] PCI: acpiphp_ibm: add __ro_after_init to ibm_apci_table_attr

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PCI: acpiphp_ibm: add __ro_after_init to ibm_apci_table_attr
Date	2017-01-04 00:20 +0100
Message-ID	<sVGx4-4OV-7@gated-at.bofh.it> (permalink)
References	<sSFxv-6wi-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 26, 2016 at 7:36 AM, Bhumika Goyal <bhumirks@gmail.com> wrote:
> The object ibm_apci_table_attr of type bin_attribute structure is not
> modified after getting initialized by ibm_acpiphp_init. Apart from
> getting referenced in init it is also passed as an argument to the functions
> sysfs_{remove/create}_bin_file but both the arguments are of type const
> struct bin_attribute *. Therefore add __ro_after_init to its declaration.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/pci/hotplug/acpiphp_ibm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp_ibm.c b/drivers/pci/hotplug/acpiphp_ibm.c
> index f6221d7..188cdfa 100644
> --- a/drivers/pci/hotplug/acpiphp_ibm.c
> +++ b/drivers/pci/hotplug/acpiphp_ibm.c
> @@ -107,7 +107,7 @@ static acpi_status __init ibm_find_acpi_device(acpi_handle handle,
>
>  static acpi_handle ibm_acpi_handle;
>  static struct notification ibm_note;
> -static struct bin_attribute ibm_apci_table_attr = {
> +static struct bin_attribute ibm_apci_table_attr __ro_after_init = {
>             .attr = {
>                     .name = "apci_table",
>                     .mode = S_IRUGO,

Thanks!

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

-- 
Kees Cook
Nexus Security

Thread

[PATCH] PCI: acpiphp_ibm: add __ro_after_init to ibm_apci_table_attr Bhumika Goyal <bhumirks@gmail.com> - 2016-12-26 16:40 +0100
  Re: [PATCH] PCI: acpiphp_ibm: add __ro_after_init to ibm_apci_table_attr Kees Cook <keescook@chromium.org> - 2017-01-04 00:20 +0100
  Re: [PATCH] PCI: acpiphp_ibm: add __ro_after_init to  ibm_apci_table_attr Bjorn Helgaas <helgaas@kernel.org> - 2017-01-11 22:10 +0100

csiph-web