Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end

From	Wolfgang Reiter <wr0112358@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end
Date	2017-01-04 00:20 +0100
Message-ID	<sVGx3-4OV-1@gated-at.bofh.it> (permalink)
References	<sVliV-6vr-5@gated-at.bofh.it> <sVyJg-7Mp-7@gated-at.bofh.it> <sVzOW-jT-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Yes, genlmsg_end changes nlmsg_len field dependent on skb->tail.
After allocation in reset_per_cpu_data skb->tail is modified in
trace_drop_common via __nla_reserve_nohdr.

Best place for setting nlmsg_len to its final value is after being
swapped out in reset_per_cpu_data.

Neil Horman <nhorman@tuxdriver.com> writes:

> On Tue, Jan 03, 2017 at 09:54:19AM -0500, David Miller wrote:
>> From: Reiter Wolfgang <wr0112358@gmail.com>
>> Date: Tue,  3 Jan 2017 01:39:10 +0100
>> 
>> > Final nlmsg_len field update must reflect inserted net_dm_drop_point
>> > data.
>> > 
>> > This patch depends on previous patch:
>> > "drop_monitor: add missing call to genlmsg_end"
>> > 
>> > Signed-off-by: Reiter Wolfgang <wr0112358@gmail.com>
>> 
>> I don't understand why the current code doesn't work properly.
>> 
>> All over the tree, the pattern is:
>> 
>> 	x = genlmsg_put(skb, ...);
>> 	...
>> 	genlmsg_end(skb, x);
>> 
>> And that is exactly what the code is doing right now.
>> 
>
> Because reset_per_cpu_data should close the use of of the established skb
> that was being written to.  Without this patch we add the END tlv to the skb
> that is just getting started for use in the drop monitor, rather than for the
> skb that is getting returned for use in sending up to user space listeners.
>
> Or am I missing something?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drop_monitor: consider inserted data in genlmsg_end Reiter Wolfgang <wr0112358@gmail.com> - 2017-01-03 01:40 +0100
  Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end Neil Horman <nhorman@tuxdriver.com> - 2017-01-03 14:20 +0100
  Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end David Miller <davem@davemloft.net> - 2017-01-03 16:00 +0100
    Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end Neil Horman <nhorman@tuxdriver.com> - 2017-01-03 17:10 +0100
      Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end David Miller <davem@davemloft.net> - 2017-01-03 17:20 +0100
      Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end Wolfgang Reiter <wr0112358@gmail.com> - 2017-01-04 00:20 +0100

csiph-web