Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550196

Re: [alsa-devel] [PATCH] fsl_ssi: set fifo watermark to more reliable value

Show all headers | View raw

On Tue, Jan 3, 2017 at 4:22 PM, Caleb Crome <ccrome@gmail.com> wrote:
> From: Caleb Crome <caleb@crome.org>
>
> The fsl_ssi fifo watermark is by default set to 2 free spaces (i.e.
> activate DMA on FIFO when only 2 spaces are left.)  This means the
> DMA must service the fifo within 2 audio samples, which is just not
> enough time  for many use cases with high data rate.  In many
> configurations the audio channel slips (causing l/r swap in stereo
> configurations, or channel slipping in multi-channel configurations).
>
> This patch gives more breathing room and allows the SSI to operate
> reliably by changing the fifio refill watermark to 8.
>
> There is no change in behavior for older chips (with an 8-deep fifo).
> Only the newer chips with a 15-deep fifo get the new behavior. I
> suspect a new fifo depth setting could be optimized on the older
> chips too, but I have not tested.
>
> Signed-off-by: Caleb Crome <caleb@crome.org>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] fsl_ssi: set fifo watermark to more reliable value Caleb Crome <ccrome@gmail.com> - 2017-01-03 19:30 +0100
  Re: [alsa-devel] [PATCH] fsl_ssi: set fifo watermark to more reliable value Fabio Estevam <festevam@gmail.com> - 2017-01-03 22:10 +0100
  Re: [PATCH] fsl_ssi: set fifo watermark to more reliable value Mark Brown <broonie@kernel.org> - 2017-01-04 19:30 +0100
    Re: [PATCH] fsl_ssi: set fifo watermark to more reliable value ccrome <ccrome@gmail.com> - 2017-01-04 19:40 +0100
      Re: [PATCH] fsl_ssi: set fifo watermark to more reliable value Mark Brown <broonie@kernel.org> - 2017-01-04 19:50 +0100
  Applied "ASoC: fsl_ssi: set fifo watermark to more reliable value" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-01-04 19:50 +0100

csiph-web