Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550201

Re: [PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops

Show all headers | View raw

On Mon, Jan 2, 2017 at 6:06 AM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:
> On Mon, Dec 26, 2016 at 05:01:02PM +0530, Bhumika Goyal wrote:
>> The object armada38x_rtc_ops of type rtc_class_ops structure is not
>> modified after getting initialized by armada38x_rtc_probe. Apart from
>> getting referenced in init it is also passed as an argument to the function
>> devm_rtc_device_register but this argument is of type const struct
>> rtc_class_ops *. Therefore add __ro_after_init to its declaration.
>
> What I'd prefer here is for the structure to be duplicated, with one
> copy having the alarm methods and one which does not.  Both can then
> be made "const" (so placed into the read-only section at link time)
> and the probe function select between the two.
>
> I think that's a cleaner and better solution, even though it's
> slightly larger.
>
> I'm not a fan of __ro_after_init being used where other solutions are
> possible.

Can the pointer that points to the struct rtc_class_ops be made ro_after_init?

-Kees

-- 
Kees Cook
Nexus Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops Bhumika Goyal <bhumirks@gmail.com> - 2016-12-26 12:40 +0100
  Re: [PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-02 15:10 +0100
    Re: [PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops Kees Cook <keescook@chromium.org> - 2017-01-03 22:20 +0100
      Re: [PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-03 22:40 +0100
        Re: [PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-03 23:00 +0100
          Re: [PATCH] rtc: armada38x: add __ro_after_init to  armada38x_rtc_ops Julia Lawall <julia.lawall@lip6.fr> - 2017-01-04 12:00 +0100
            Re: [PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-01-04 12:10 +0100
              Re: [PATCH] rtc: armada38x: add __ro_after_init to  armada38x_rtc_ops Julia Lawall <julia.lawall@lip6.fr> - 2017-01-04 12:50 +0100
                Re: [PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-04 13:20 +0100
                Re: [PATCH] rtc: armada38x: add __ro_after_init to  armada38x_rtc_ops Julia Lawall <julia.lawall@lip6.fr> - 2017-01-04 13:30 +0100
                Re: [PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-04 14:20 +0100
                Re: [PATCH] rtc: armada38x: add __ro_after_init to  armada38x_rtc_ops Julia Lawall <julia.lawall@lip6.fr> - 2017-01-04 14:50 +0100
                Re: [PATCH] rtc: armada38x: add __ro_after_init to armada38x_rtc_ops Kees Cook <keescook@chromium.org> - 2017-01-04 23:00 +0100

csiph-web