Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550136

Re: [PATCH 1/4] perf, tools: Add probing for xed

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/4] perf, tools: Add probing for xed
Date 2017-01-03 20:50 +0100
Message-ID <sVDfQ-2y2-39@gated-at.bofh.it> (permalink)
References <sVtgu-40T-15@gated-at.bofh.it> <sVtgu-40T-37@gated-at.bofh.it> <sVyJh-7Mp-25@gated-at.bofh.it> <sVz2x-8cw-15@gated-at.bofh.it> <sVCjL-1Wi-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 03, 2017 at 03:39:46PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 03, 2017 at 07:11:06AM -0800, Andi Kleen escreveu:
> > > please don't put it in FEATURE_DISPLAY.. AFAICS there's not any xed
> > > package yet, just the sources, so the "xed: OFF" build message would
> > > bother almost everyone probably for long time..
> > 
> > It should be eventually packaged. How would people know they are missing
> > it without displaying it? I think it has to, otherwise most people will
> > miss out on the feature. Silent failure is bad.

make VF=1 will show it

> Right, you have a point, we should have some warning to the user for
> when features are not being automatically probed for, i.e. extra
> features may be enabled using special command line settings, read the
> docs to see how.

we could print out one line saying we did not detect all the features

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] perf, tools: Add probing for xed Andi Kleen <andi@firstfloor.org> - 2017-01-03 10:10 +0100
  Re: [PATCH 1/4] perf, tools: Add probing for xed Jiri Olsa <jolsa@redhat.com> - 2017-01-03 16:00 +0100
    Re: [PATCH 1/4] perf, tools: Add probing for xed Andi Kleen <ak@linux.intel.com> - 2017-01-03 16:20 +0100
      Re: [PATCH 1/4] perf, tools: Add probing for xed Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-03 19:50 +0100
        Re: [PATCH 1/4] perf, tools: Add probing for xed Jiri Olsa <jolsa@redhat.com> - 2017-01-03 20:50 +0100
    Re: [PATCH 1/4] perf, tools: Add probing for xed Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-03 16:20 +0100
  Re: [PATCH 1/4] perf, tools: Add probing for xed Jiri Olsa <jolsa@redhat.com> - 2017-01-08 15:30 +0100
  Re: [PATCH 1/4] perf, tools: Add probing for xed Jiri Olsa <jolsa@redhat.com> - 2017-01-08 15:30 +0100
    Re: [PATCH 1/4] perf, tools: Add probing for xed Andi Kleen <andi@firstfloor.org> - 2017-01-10 02:00 +0100

csiph-web