Re: [PATCH 6/7] perf record: Add switch-output size option argument

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/7] perf record: Add switch-output size option argument
Date	2017-01-03 20:50 +0100
Message-ID	<sVDfQ-2y2-35@gated-at.bofh.it> (permalink)
References	<sVsDM-3nL-5@gated-at.bofh.it> <sVsDM-3nL-23@gated-at.bofh.it> <sVzlT-8kf-3@gated-at.bofh.it> <sVA8i-ua-9@gated-at.bofh.it> <sVA8i-ua-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 03, 2017 at 09:23:18AM -0700, David Ahern wrote:
> On 1/3/17 9:12 AM, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jan 03, 2017 at 08:33:35AM -0700, David Ahern escreveu:
> >> On 1/3/17 1:19 AM, Jiri Olsa wrote:
> >>> It's now possible to specify the threshold size for
> >>> perf.data like:
> >>>
> >>>   $ perf record --switch-output=2G ...
> >>>
> >>> Once it's reached, the current data are dumped in to the
> >>> perf.data.<timestamp> file and session does on.
> >>
> >> How about something like max-file-size instead of switch-output?
> > 
> > Well, I think he wants to use the "switch-output" semantic, which will
> > go on "slicing" the output into multiple files according to the
> > specified criteria, be it the existing signal one or a file size.

yea, I wanted to keep current option.. which I think
we will have to keep in any case

> > 
> > "max-file-size" looks like a hard limit, no hint about producing
> > multiple files.
> 
> Sure, my point is that switch-output is an odd name for the option.
> 
> file-slice?

I actually don't mind the current switch-output=signal/size/time,
because we change/switch the output file on various conditions:
  signal/size/time ;-)

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 6/7] perf record: Add switch-output size option argument Jiri Olsa <jolsa@kernel.org> - 2017-01-03 09:30 +0100
  Re: [PATCH 6/7] perf record: Add switch-output size option argument Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-03 15:30 +0100
    Re: [PATCH 6/7] perf record: Add switch-output size option argument Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-03 15:30 +0100
    Re: [PATCH 6/7] perf record: Add switch-output size option argument Jiri Olsa <jolsa@redhat.com> - 2017-01-03 15:40 +0100
      Re: [PATCH 6/7] perf record: Add switch-output size option argument Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-03 16:00 +0100
  Re: [PATCH 6/7] perf record: Add switch-output size option argument David Ahern <dsahern@gmail.com> - 2017-01-03 16:40 +0100
    Re: [PATCH 6/7] perf record: Add switch-output size option argument Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-03 17:30 +0100
      Re: [PATCH 6/7] perf record: Add switch-output size option argument David Ahern <dsahern@gmail.com> - 2017-01-03 17:30 +0100
        Re: [PATCH 6/7] perf record: Add switch-output size option argument Jiri Olsa <jolsa@redhat.com> - 2017-01-03 20:50 +0100

csiph-web