Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550125

Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2

Show all headers | View raw

Hi Florian,

Florian Fainelli <f.fainelli@gmail.com> writes:

>>>> The current HWMON support in DSA in embedded in the legacy code.
>>>> Extract it to its own file and register it in the newer DSA code.
>>>
>>> I would really prefer not to do this.
>>>
>>> The temperature sensor is in the embedded PHYs of the switch. Many of
>>> Marvell discrete PHYs also have the same temperature sensor. The
>>> correct thing to do is move this code into drivers/net/phy/marvell.c.
>> 
>> I agree that the temperature code in the mv88e6xxx driver must be moved
>> to the Marvell PHY driver.
>> 
>> However I still think this patchset is still valuable because at least
>> it isolates the HWMON code in DSA which is good, and I think some chips
>> do have temperature sensors in their cores, not in their PHYs. So the
>> new DSA code should benefit from the HWMON support instead of
>> considering this a regression for its users.
>
> Well, I agree with the regression part, but an argument could
> definitively be made that HWMON did not belong in the DSA layer in the
> first place, unless we were able to find some commonality between
> devices which AFAICT, we could not yet.
>
> I don't have a strong preference, but it seems like the HWMON
> functionality should have been part of the switch and/or PHY driver all
> along.

I see what you mean. Indeed the drivers could register their own HWMON
device until we figure any many chips have an embedded temperature
sensor in their core.

What about sending the patch 2/3 on its own?

Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2 Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-03 19:20 +0100
  [PATCH net-next 1/3] net: dsa: remove out label in dsa_switch_setup_one Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-03 19:20 +0100
    Re: [PATCH net-next 1/3] net: dsa: remove out label in  dsa_switch_setup_one Andrew Lunn <andrew@lunn.ch> - 2017-01-03 19:40 +0100
      Re: [PATCH net-next 1/3] net: dsa: remove out label in dsa_switch_setup_one Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-03 20:20 +0100
  [PATCH net-next 2/3] net: dsa: move HWMON support to its own file Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-03 19:20 +0100
  Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2 Andrew Lunn <andrew@lunn.ch> - 2017-01-03 19:40 +0100
    Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2 Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-03 20:30 +0100
      Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2 Florian Fainelli <f.fainelli@gmail.com> - 2017-01-03 20:40 +0100
        Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2 Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-03 20:50 +0100
        Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2 Andrew Lunn <andrew@lunn.ch> - 2017-01-03 21:20 +0100

csiph-web