Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1550027

Re: [PATCH 2/4] Documetation: samsung-phy: add the exynos-pcie-phy binding

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/4] Documetation: samsung-phy: add the exynos-pcie-phy binding
Date 2017-01-03 19:10 +0100
Message-ID <sVBH3-1F1-5@gated-at.bofh.it> (permalink)
References <sTjOh-6Vy-3@gated-at.bofh.it> <sTjOi-6Vy-17@gated-at.bofh.it> <sTjOi-6Vy-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Dec 28, 2016 at 07:34:52PM +0900, Jaehoon Chung wrote:
> Adds the exynos-pcie-phy binding for Exynos PCIe PHY.
> This is for using generic PHY framework.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  .../devicetree/bindings/phy/samsung-phy.txt        | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> index 9872ba8..1cbc15f 100644
> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> @@ -191,3 +191,26 @@ Example:
>  		usbdrdphy0 = &usb3_phy0;
>  		usbdrdphy1 = &usb3_phy1;
>  	};
> +
> +Samsung Exynos SoC series PCIe PHY controller
> +--------------------------------------------------
> +Required properties:
> +- compatible : Should be set to "samsung,exynos5440-pcie-phy"
> +- #phy-cells : Must be zero
> +- reg : a register used by phy driver.
> +
> +Required properies for child node:
> +- reg : a block register used by phy driver.

There's no need for this. Either just make the length 0x1040 or add a 
2nd address to the parent reg prop.

> +
> +Example:
> +	pcie_phy0: pcie-phy@270000 {
> +		#phy-cells = <0>;
> +		compatible = "samsung,exynos5440-pcie-phy";
> +		reg = <0x270000 0x1000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +		block@271000 {
> +			reg = <0x271000 0x40>;
> +		};
> +	};
> -- 
> 2.10.2
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] PCI: exynos: use the PHY generic framework Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-28 11:40 +0100
  [PATCH 2/4] Documetation: samsung-phy: add the exynos-pcie-phy binding Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-28 11:40 +0100
    Re: [PATCH 2/4] Documetation: samsung-phy: add the exynos-pcie-phy  binding Rob Herring <robh@kernel.org> - 2017-01-03 19:10 +0100
      Re: [PATCH 2/4] Documetation: samsung-phy: add the exynos-pcie-phy  binding Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 09:20 +0100
  [PATCH 3/4] Documetation: binding: modify the exynos5440 pcie binding Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-28 11:40 +0100
    Re: [PATCH 3/4] Documetation: binding: modify the exynos5440 pcie  binding Rob Herring <robh@kernel.org> - 2017-01-03 21:00 +0100
      Re: [PATCH 3/4] Documetation: binding: modify the exynos5440 pcie  binding Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 09:40 +0100
  Re: [PATCH 0/4] PCI: exynos: use the PHY generic framework Krzysztof Kozlowski <krzk@kernel.org> - 2016-12-30 17:00 +0100
    Re: [PATCH 0/4] PCI: exynos: use the PHY generic framework Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-02 10:50 +0100

csiph-web