Re: [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node
Date	2017-01-03 18:10 +0100
Message-ID	<sVAL0-10T-15@gated-at.bofh.it> (permalink)
References	<sVsaJ-2WV-3@gated-at.bofh.it> <sVsaJ-2WV-11@gated-at.bofh.it> <sVsaJ-2WV-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 03, 2017 at 04:57:17PM +0900, Jaechul Lee wrote:
> Add DT node support for TM2 touchkey device.
> 
> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>

The order of sign-offs should follow the order of "who touched it". I
assume that the real order was like this:
1. Initially create by Beomho,
2. Adjustments by Andi,
3. Final adjustments and sending by you.

If that is correct then the order should be 1->2->3.

Beside of that, patch looks good.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node Jaechul Lee <jcsing.lee@samsung.com> - 2017-01-03 09:00 +0100
  Re: [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-03 14:20 +0100
  Re: [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-03 18:10 +0100

csiph-web