Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1549142

Re: [PATCH v3] rfkill: Add rfkill-any LED trigger

From Johannes Berg <johannes@sipsolutions.net>
Newsgroups linux.kernel
Subject Re: [PATCH v3] rfkill: Add rfkill-any LED trigger
Date 2017-01-02 13:30 +0100
Message-ID <sV9Ut-6L5-7@gated-at.bofh.it> (permalink)
References <sQKKZ-13H-15@gated-at.bofh.it> <sV8OJ-64t-21@gated-at.bofh.it> <sV8OJ-64t-19@gated-at.bofh.it> <sV9Ut-6L5-9@gated-at.bofh.it> <sV8OJ-64t-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> I'm not super happy with this conditional locking - can't we instead
> defer the necessary work to a workqueue, or so, for purposes of the
> LED?

Actually, since you can sleep in here, and do various other things like
scheduling etc. this can't even be correct as is - one thread might be
in the probe and another might also attempt to do some operations that
require the lock but now don't take it.

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] rfkill: Add rfkill-any LED trigger Michał Kępień <kernel@kempniu.pl> - 2016-12-21 09:50 +0100
  Re: [PATCH v3] rfkill: Add rfkill-any LED trigger Johannes Berg <johannes@sipsolutions.net> - 2017-01-02 12:20 +0100
    Re: [PATCH v3] rfkill: Add rfkill-any LED trigger Johannes Berg <johannes@sipsolutions.net> - 2017-01-02 13:30 +0100
      Re: [PATCH v3] rfkill: Add rfkill-any LED trigger Johannes Berg <johannes@sipsolutions.net> - 2017-01-02 14:00 +0100
  [PATCH v3] rfkill: Add rfkill-any LED trigger Mike Krinkin <krinkin.m.u@gmail.com> - 2017-01-02 12:50 +0100

csiph-web