Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1549012

Re: [PATCH] Update pptp handling to avoid null pointer deref.

Show all headers | View raw

On Mon, Jan 2, 2017 at 5:07 AM, David Miller <davem@davemloft.net> wrote:
> From: Ian Kumlien <ian.kumlien@gmail.com>
> Date: Mon,  2 Jan 2017 00:19:36 +0100
>
>> __skb_flow_dissect can be called with a skb or a data packet, either
>> can be NULL. All calls seems to have been moved to __skb_header_pointer
>> except the pptp handling which is still calling skb_header_pointer.
>>
>> skb_header_pointer will use skb->data and thus:
>  ...
>> ---
>>
>> Signed-off-by: Ian Kumlien <ian.kumlien@gmail.com>
>
> You need to fix some parts of your submission.
>
> Do not put the signoff after the "---", git will remove all text
> after that "---" from the commit message.

Sorry, I tend to do that automatically

> You must include a proper "Fixes: " tag which indicates which change
> introduced this regression.  This is critical for analyzing your fix
> and also for figuring out which -stable releases your fix should be
> backported to.

I it's supposed to be added after 4.7 but i can't find it in 4.8, will
send it as a stable patch for 4.9

> In this case the guilty commit is ab10dccb1160 ("rps: Inspect PPTP
> encapsulated by GRE to get flow hash")

Thanks, =)

Now patch is incomming

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Update pptp handling to avoid null pointer deref. Ian Kumlien <ian.kumlien@gmail.com> - 2017-01-02 00:30 +0100
  Re: [PATCH] Update pptp handling to avoid null pointer deref. David Miller <davem@davemloft.net> - 2017-01-02 05:10 +0100
    Re: [PATCH] Update pptp handling to avoid null pointer deref. Ian Kumlien <ian.kumlien@gmail.com> - 2017-01-02 09:10 +0100
  [PATCH] Update pptp handling to avoid null pointer deref. v2 Ian Kumlien <ian.kumlien@gmail.com> - 2017-01-02 09:20 +0100
  [PATCH] Update pptp handling to avoid null pointer deref. v2 Ian Kumlien <ian.kumlien@gmail.com> - 2017-01-02 09:20 +0100
    Re: [PATCH] Update pptp handling to avoid null pointer deref. v2 David Miller <davem@davemloft.net> - 2017-01-02 19:00 +0100

csiph-web