Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1548829

Re: [PATCH v3] net: ethernet: faraday: To support device tree usage.

Show all headers | View raw

On Saturday, December 31, 2016 10:48:39 AM CET Florian Fainelli wrote:
> 
> On 12/29/2016 11:37 PM, Greentime Hu wrote:
> > Signed-off-by: Greentime Hu <green.hu@gmail.com>
> 
> This is not enough, you need to add a Device Tree binding document under
> Documentation/devicetree/bindings/net/ which documents this compatible
> string, as well as additional properties that may be required to
> describe this hardware block.

We already have

Documentation/devicetree/bindings/net/moxa,moxart-mac.txt

for the same hardware (though used by a different driver).

I'd suggest renaming that one to a more generic file name and
adding the new compatible string there.

Aside from that, every patch should also have a changelog comment.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] net: ethernet: faraday: To support device tree usage. Greentime Hu <green.hu@gmail.com> - 2016-12-30 09:10 +0100
  Re: [PATCH v3] net: ethernet: faraday: To support device tree usage. Florian Fainelli <f.fainelli@gmail.com> - 2016-12-31 19:50 +0100
    Re: [PATCH v3] net: ethernet: faraday: To support device tree usage. Arnd Bergmann <arnd@arndb.de> - 2016-12-31 21:30 +0100
      Re: [PATCH v3] net: ethernet: faraday: To support device tree usage. Arnd Bergmann <arnd@arndb.de> - 2017-01-03 14:30 +0100

csiph-web