Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1548827

Stopping watchdog in watchdog driver remove functions

Show all headers | View raw

Hi,

I noticed that several watchdog drivers stop the watchdog in trhe driver remove function.
A non-exhaustive list of drivers doing that is

	drivers/watchdog/bcm7038_wdt.c
	drivers/watchdog/cadence_wdt.c
	drivers/watchdog/imgpdc_wdt.c
	drivers/watchdog/jz4740_wdt.c
	drivers/watchdog/kempld_wdt.c
	drivers/watchdog/max77620_wdt.c
	drivers/watchdog/moxart_wdt.c
	drivers/watchdog/sama5d4_wdt.c
	drivers/watchdog/tangox_wdt.c
	drivers/watchdog/tegra_wdt.c

Since a watchdog has to be closed for its driver to be removable, one situation
where a watchdog is still running on unload is where the watchdog was opened but
not closed properly (eg by killing the watchdog application, or if the 'nowayout'
flag is set).

Given that, does it even make sense to stop the watchdog in the remove function ?
Should it even be permitted ?

Thanks,
Guenter

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Stopping watchdog in watchdog driver remove functions Guenter Roeck <linux@roeck-us.net> - 2016-12-31 20:50 +0100
  Re: Stopping watchdog in watchdog driver remove functions Wim Van Sebroeck <wim@iguana.be> - 2017-01-01 12:20 +0100
    Re: Stopping watchdog in watchdog driver remove functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-01 16:30 +0100
    Re: Stopping watchdog in watchdog driver remove functions Guenter Roeck <linux@roeck-us.net> - 2017-01-01 18:00 +0100

csiph-web