Re: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC
Date	2016-12-30 20:50 +0100
Message-ID	<sUblE-cG-43@gated-at.bofh.it> (permalink)
References	<sSEL7-5Z9-11@gated-at.bofh.it> <sSEL7-5Z9-9@gated-at.bofh.it> <sU4WS-4sk-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Linus Walleij <linus.walleij@linaro.org> [161230 04:56]:
> On Mon, Dec 26, 2016 at 3:33 PM, André Przywara <andre.przywara@arm.com> wrote:
> 
> > So while this patch technically looks correct, I was wondering if we
> > should really explore the possibility of making the whole of sunxi
> > pinctrl DT controlled.
> > I brought this up a while ago, but people weren't overly enthusiastic
> > about it, though their argument weren't really convincing to me[1].
> >
> > So:
> > As this "driver" here is basically a table linking GPIO bit settings
> > (the actual mux value) to names and every pin we care about needs to be
> > enumerated in the DT anyway, why not just add something like:
> > allwinner,pinmux = <4>;
> > to each pin(group) in the DT and get rid of this "driver" file here
> > entirely?
> 
> I'm open to that if you can use pinctrl-single which is in the kernel
> for this purpose only, and is used with both OMAPs and HiSilicon.
> 
> It recently was improved and will be improved more in this cycle,
> see for example:
> commit 42124bc598f64f84b3335d5a058304207695b84f
> pinctrl: Introduce generic #pinctrl-cells and pinctrl_parse_index_with_args
> 
> > (...) Also I guess the common sunxi
> > pinctrl driver code needs some significant rework.
> 
> I would guess is just needs replacing with pinctrl-single in that case.

And if pinctrl-single won't work then it is now also be easier to make
hardware specific drivers too using #pinctrl-cells + GENERIC_PINCTRL_GROUPS +
GENERIC_PINMUX_FUNCTIONS.

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for  Allwinner H5 SoC André Przywara <andre.przywara@arm.com> - 2016-12-26 15:50 +0100
  Re: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for  Allwinner H5 SoC Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 14:00 +0100
    Re: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for  Allwinner H5 SoC Tony Lindgren <tony@atomide.com> - 2016-12-30 20:50 +0100

csiph-web