Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.datemas.de!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Stefan Wahren <stefan.wahren@i2se.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()
Date	Fri, 30 Dec 2016 21:20:01 +0100
Message-ID	<sUbOF-DA-1@gated-at.bofh.it> (permalink)
References	<sRGlX-4lT-7@gated-at.bofh.it> <sSLCV-24U-1@gated-at.bofh.it> <sUaIW-8p1-23@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	7bit
Importance	Medium
X-Mailer	Open-Xchange Mailer v7.8.1-Rev28
X-Originating-Client	open-xchange-appsuite
X-Provags-ID	V03:K0:yCW5NI9xXeoFdYYWBObB0wnQEmh0eglnykt81NS44TV1eq5OqaK 7jsAd5cjEBGaY2w/xtN860+HCd0blcBmpOfC/I5V+GJz+uy8QhSker60R1J/J9d8tiGkPWn RyuG5WdW2mqyE9q8lq6ecg5ygz5mlbAMaRVNAB49B89ZKPH2PONb9XhPW3qKTAm0q0xG4K+ iVlNPxQlTBVgPdKP4XrCA==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:ilnE5u2Qsok=:BYkNro00IjgtDh17HvhzMu 3QBxFZIE5DIqJf2mlkL1tpL2kbjvCeIN7hDp7EAKZVfAM25mc4PiTvOc7xpJR+O/ZnlSqPl+K HQ1c0/Vkkt1CP5MoDtXC01ZEPAocom1Xrb03fJywYAg1EjCxPzmh3zbs1mnVFfNMns7TFlpzt osbGAyhsZTv702E4DHImJVYMPxxmYwIpfxPbLftjDVjA070QkoIhcrUnqv3HYSVgMLhzCQomv 9gD8TZHHrifDSvwAXSEJSulTrgoESQeuRDGsDPTQsmVDP2Sxn+pkRiuBF1qkDb3pJCI15GtMp 3XUsuNP4DGcJzHy4X8pudDVq+/fomL46bTl51pgCT7x7hKbfqTIwSHwo0udZiOU+rr5NyMNF/ f7U3uA+hAUpBhMc0gKN4JAd7/U/+JcNpw8KDKcp4vbhTqkTuQRLcXKiXi8mPlxmb3jx2dfc1r ySnhGnK3O6uyGHM2l4P/TPYKTWx/k/8DyPO7q/x2w5h7AzeT1mHCZJ7JIqrHR/376OyPVvmOe Wx+PZBgnLDsp0l+kCSuyhqflZGA/+xX52dc6ubojahNzpi/zyLB7pg2MwF4TWjdLWyfGjxoAQ X7kKI2dmXA4blDotHQnN7XYSkjo9vd35l5ge+j9dEE3sF7rS0qwDw2dNZ2cff45gP3ZXpbshO yvxGndHtk22AuKQ2yT7VpX77jNve1dWJvLRBx9k0JNvid5FM5w6/3aaofzeJQ4lHN7IQ4W4wy PkJ/Fq+cB7dM+JDD
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	lee.jones@linaro.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org, linux-iio@vger.kernel.org
X-Original-Date	Fri, 30 Dec 2016 21:16:14 +0100 (CET)
X-Original-Message-ID	<918653344.138229.1483128974311@email.1und1.de>
X-Original-References	<1482531319-26935-1-git-send-email-khoroshilov@ispras.ru> <1600801097.88831.1482789844722@email.1und1.de> <104b932a-86b3-1ef0-29d2-d27eade1f97d@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1548728

Show key headers only | View raw

> Jonathan Cameron <jic23@kernel.org> hat am 30. Dezember 2016 um 20:09 geschrieben:
> 
> 
> On 26/12/16 22:04, Stefan Wahren wrote:
> > 
> >> Alexey Khoroshilov <khoroshilov@ispras.ru> hat am 23. Dezember 2016 um 23:15 geschrieben:
> >>
> >>
> >> During transition to using devm_input_allocate_device()
> >> goto to resource deallocation block was replaced by return
> >> in case of error in iio_device_register().
> >> That is wrong since resources are left undeallocated.
> >>
> >> Found by Linux Driver Verification project (linuxtesting.org).
> >>
> >> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> >> Fixes: 962ed43a3eac ("iio: mxs-lradc: remove mxs_lradc_ts_unregister")
> > 
> > Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
> > 
> > But since Ksenija's patch series [1] (which doesn't have this issue) this patch is only relevant for stable.
> It's slightly doubtful as stable material as well unless it causes
> a crash. Obviously failing to clean up isn't good, but its not critical
> enough to justify the churn. 
> 
> Good find though.
> 
> Should you wish to post it to stable and let the stable maintainers make
> a decision feel free to do so.

No, i don't have any plans for that.

> 
> Jonathan
> > 
> > Thanks
> > 
> > [1] - http://marc.info/?l=linux-iio&m=148131774219426&w=2
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-12-23 23:20 +0100
  Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe() Stefan Wahren <stefan.wahren@i2se.com> - 2016-12-26 23:10 +0100
    Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe() Jonathan Cameron <jic23@kernel.org> - 2016-12-30 20:10 +0100
      Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe() Stefan Wahren <stefan.wahren@i2se.com> - 2016-12-30 21:20 +0100

csiph-web