Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1548865
| From | Lorenzo Colitti <lorenzo@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: socket: don't set sk_uid to garbage value in ->setattr() |
| Date | 2017-01-01 09:00 +0100 |
| Message-ID | <sUJdD-5XG-3@gated-at.bofh.it> (permalink) |
| References | <sUf5T-2Uw-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Dec 31, 2016 at 8:42 AM, Eric Biggers <ebiggers3@gmail.com> wrote:
> ->setattr() was recently implemented for socket files to sync the socket
> inode's uid to the new 'sk_uid' member of struct sock. It does this by
> copying over the ia_uid member of struct iattr. However, ia_uid is
> actually only valid when ATTR_UID is set in ia_valid, indicating that
> the uid is being changed, e.g. by chown.
> [...]
> - if (!err) {
> + if (!err && (iattr->ia_valid & ATTR_UID)) {
Oops. Thanks for fixing this. Unit tested in
https://android-review.googlesource.com/316594 .
Tested-by: Lorenzo Colitti <lorenzo@google.com>
Acked-by: Lorenzo Colitti <lorenzo@google.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: socket: don't set sk_uid to garbage value in ->setattr() Eric Biggers <ebiggers3@gmail.com> - 2016-12-31 00:50 +0100
Re: [PATCH] net: socket: don't set sk_uid to garbage value in ->setattr() David Miller <davem@davemloft.net> - 2016-12-31 18:40 +0100
Re: [PATCH] net: socket: don't set sk_uid to garbage value in ->setattr() Lorenzo Colitti <lorenzo@google.com> - 2017-01-01 09:00 +0100
Re: [PATCH] net: socket: don't set sk_uid to garbage value in ->setattr() David Miller <davem@davemloft.net> - 2017-01-01 18:00 +0100
csiph-web