Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1548618

Re: [PATCH 3/5] pinctrl: core: Add generic pinctrl functions for managing groups

Show all headers | View raw

On Tue, Dec 27, 2016 at 6:20 PM, Tony Lindgren <tony@atomide.com> wrote:

> We can add generic helpers for function handling for cases where the pin
> controller driver does not need to use static arrays.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Patch applied.

> +config GENERIC_PINMUX
> +       bool
> +       select PINMUX

I renamed this GENERIC_PINMUX_FUNCTIONS

> +       INIT_RADIX_TREE(&pctldev->pin_function_tree, GFP_KERNEL);

#ifdefed this

> +       struct radix_tree_root pin_function_tree;
>         unsigned int num_groups;
> +       unsigned int num_functions;

#ifdefed these

>  /**
> + * struct function_desc - generic function descriptor
> + * @name: name of the function
> + * @group_names: array of pin group names
> + * @num_group_names: number of pin group names
> + * @data: pin controller driver specific data
> + */
> +struct function_desc {
> +       const char *name;
> +       const char **group_names;
> +       int num_group_names;
> +       void *data;
> +};

And moved this into pinmux.h

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] pinctrl: core: Add generic pinctrl functions for managing groups Tony Lindgren <tony@atomide.com> - 2016-12-27 18:30 +0100
  Re: [PATCH 3/5] pinctrl: core: Add generic pinctrl functions for  managing groups Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 15:10 +0100
  Re: [PATCH 3/5] pinctrl: core: Add generic pinctrl functions for  managing groups Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 15:30 +0100
  Re: [3/5] pinctrl: core: Add generic pinctrl functions for managing  groups Gary Bisson <gary.bisson@boundarydevices.com> - 2017-01-02 17:30 +0100
    Re: [3/5] pinctrl: core: Add generic pinctrl functions for managing  groups Tony Lindgren <tony@atomide.com> - 2017-01-02 18:10 +0100

csiph-web