Re: [PATCH 1/5] [media] ir-rx51: port to rc-core

From	Sean Young <sean@mess.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] [media] ir-rx51: port to rc-core
Date	2016-12-30 14:10 +0100
Message-ID	<sU56x-4KU-9@gated-at.bofh.it> (permalink)
References	<sQwRH-fa-5@gated-at.bofh.it> <sQwRI-fa-15@gated-at.bofh.it> <sU3Hr-3Ks-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Ivo,,

On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivaylo Dimitrov wrote:
> On 20.12.2016 19:50, Sean Young wrote:
> >This driver was written using lirc since rc-core did not support
> >transmitter-only hardware at that time. Now that it does, port
> >this driver.
> >
> >Compile tested only.
> >
> 
> I guess after that change, there will be no more /dev/lircN device, right?
> Neither will LIRC_XXX IOCTL codes be supported?

Quite the opposite, /dev/lircN and all the LIRC_XXX ioctls will still be
supported through ir-lirc-codec.c.

By using rc-core, the driver will be more succinct, and some latent bugs
will be fixed. For example, at the moment it is possible to write hours
of IR data and keep the n900 from suspending.

I'm working on lirc scancode sending and receiving using the IR encoders,
and when that is in place, any rc-core driver will get it for free.

> That looks to me as a completely new driver, not a port to new API.
> 
> Right now there are applications using the current behaviour (pierogi for
> example), which will be broken by the change.

Nothing should break.

Thanks,

Sean

Thread

[PATCH 1/5] [media] ir-rx51: port to rc-core Sean Young <sean@mess.org> - 2016-12-20 19:00 +0100
  Re: [PATCH 1/5] [media] ir-rx51: port to rc-core Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-12-30 12:40 +0100
    Re: [PATCH 1/5] [media] ir-rx51: port to rc-core Sean Young <sean@mess.org> - 2016-12-30 14:10 +0100
      Re: [PATCH 1/5] [media] ir-rx51: port to rc-core Sean Young <sean@mess.org> - 2016-12-30 14:40 +0100
        Re: [PATCH 1/5] [media] ir-rx51: port to rc-core Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-12-30 15:00 +0100
          Re: [PATCH 1/5] [media] ir-rx51: port to rc-core Sean Young <sean@mess.org> - 2016-12-30 16:50 +0100

csiph-web