Re: [PATCH v2 4/8] PM / devfreq: exynos-ppmu: Show the registred device for ppmu device

From	Chanwoo Choi <cwchoi00@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/8] PM / devfreq: exynos-ppmu: Show the registred device for ppmu device
Date	2016-12-30 13:10 +0100
Message-ID	<sU4at-4aa-1@gated-at.bofh.it> (permalink)
References	<sTl3I-7Id-19@gated-at.bofh.it> <sTl3H-7Id-9@gated-at.bofh.it> <sTl3I-7Id-17@gated-at.bofh.it> <sU2Ln-39f-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-12-30 19:35 GMT+09:00 MyungJoo Ham <myungjoo.ham@samsung.com>:
> On Wed, Dec 28, 2016 at 8:56 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> This patch just adds the simple log to show the PPMU device's registration
>> during the kernel booting.
>>
>> Cc: Kukjin Kim <kgene@kernel.org>
>> Cc: Krzysztof Kozlowski <krzk@kernel.org>
>> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
>> Cc: linux-samsung-soc@vger.kernel.org
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>  drivers/devfreq/event/exynos-ppmu.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
>> index fb3706faf5bd..9b5294d0bff4 100644
>> --- a/drivers/devfreq/event/exynos-ppmu.c
>> +++ b/drivers/devfreq/event/exynos-ppmu.c
>> @@ -591,7 +591,7 @@ static int exynos_ppmu_parse_dt(struct platform_device *pdev,
>>         info->ppmu.clk = devm_clk_get(dev, "ppmu");
>>         if (IS_ERR(info->ppmu.clk)) {
>>                 info->ppmu.clk = NULL;
>> -               dev_warn(dev, "cannot get PPMU clock\n");
>> +               dev_dbg(dev, "cannot get PPMU clock\n");
>
> Do you really want not to emit warning with a clock not found?

The clock is now optional on the exynos-bus.c driver. But we better to
keep the warning message. Instead, I'll try to add the clock to PPMU
which is missing the clock.

I'll send the next version.

[snip]

-- 
Best Regards,
Chanwoo Choi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/8] PM / devfreq: exynos-ppmu: Show the registred device  for ppmu device Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-28 13:00 +0100
  Re: [PATCH v2 4/8] PM / devfreq: exynos-ppmu: Show the registred  device for ppmu device MyungJoo Ham <myungjoo.ham@samsung.com> - 2016-12-30 11:40 +0100
    Re: [PATCH v2 4/8] PM / devfreq: exynos-ppmu: Show the registred  device for ppmu device Chanwoo Choi <cwchoi00@gmail.com> - 2016-12-30 13:10 +0100

csiph-web