Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1548539
| From | "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 3/7] remoteproc: qcom: Add and initialize proxy and active regulators. |
| Date | 2016-12-30 12:10 +0100 |
| Message-ID | <sU3ep-3yT-9@gated-at.bofh.it> (permalink) |
| References | <sODkB-5Hj-5@gated-at.bofh.it> <sODkB-5Hj-3@gated-at.bofh.it> <sRjpo-6on-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/23/2016 3:16 AM, Bjorn Andersson wrote:
> On Thu 15 Dec 04:21 PST 2016, Avaneesh Kumar Dwivedi wrote:
>
>> -static int q6v5_regulator_init(struct q6v5 *qproc)
>> +static int q6v5_regulator_init(struct device *dev, struct reg_info *regs,
>> + const struct qcom_mss_reg_res *reg_res)
>> {
>> - int ret;
>> + int count = 0;
>> + int rc;
>> + int i;
>>
>> - qproc->supply[Q6V5_SUPPLY_CX].supply = "cx";
>> - qproc->supply[Q6V5_SUPPLY_MX].supply = "mx";
>> - qproc->supply[Q6V5_SUPPLY_MSS].supply = "mss";
>> - qproc->supply[Q6V5_SUPPLY_PLL].supply = "pll";
>> + while (reg_res[count].supply)
>> + count++;
>>
>> - ret = devm_regulator_bulk_get(qproc->dev,
>> - ARRAY_SIZE(qproc->supply), qproc->supply);
>> - if (ret < 0) {
>> - dev_err(qproc->dev, "failed to get supplies\n");
>> - return ret;
>> - }
>> + for (i = 0; i < count; i++) {
> As with the clock init you can squash these two loops into one now.
OK.
>
> [..]
>> static const struct rproc_hexagon_res msm8916_mss = {
>> .hexagon_mba_image = "mba.mbn",
>> + .proxy_supply = (struct qcom_mss_reg_res[]) {
>> + {
>> + .supply = "mx",
>> + .uV = 1050000,
>> + },
>> + {
>> + .supply = "cx",
>> + .uA = 100000,
>> + },
>> + {
>> + .supply = "pll",
>> + .uA = 100000,
>> + },
>> + { NULL }
> It's idiomatic to use {} instead of { NULL }, so please update this (but
> not in the clock patch).
OK.
>
> As with the clock patch, please squash patch 4 into this one - so that
> we have regulators before and after applying this single patch.
OK.
> Regards,
> Bjorn
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 0/7] remoteproc: qcom: Add support of mss rproc for msm8996. Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> - 2016-12-15 13:30 +0100
[PATCH v5 3/7] remoteproc: qcom: Add and initialize proxy and active regulators. Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> - 2016-12-15 13:30 +0100
Re: [PATCH v5 3/7] remoteproc: qcom: Add and initialize proxy and active regulators. Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-12-22 22:50 +0100
Re: [PATCH v5 3/7] remoteproc: qcom: Add and initialize proxy and active regulators. "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org> - 2016-12-30 12:10 +0100
Re: [PATCH v5 3/7] remoteproc: qcom: Add and initialize proxy and active regulators. Stephen Boyd <sboyd@codeaurora.org> - 2016-12-29 00:40 +0100
[PATCH v5 1/7] remoteproc: qcom: Add private resource struct and new compatible. Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> - 2016-12-15 13:30 +0100
[PATCH v5 4/7] remoteproc: qcom: Modify regulator enable and disable interface. Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> - 2016-12-15 13:30 +0100
Re: [PATCH v5 4/7] remoteproc: qcom: Modify regulator enable and disable interface. Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-12-23 01:20 +0100
[PATCH v5 2/7] remoteproc: qcom: Add and initialize proxy and active clocks. Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> - 2016-12-15 13:30 +0100
Re: [PATCH v5 2/7] remoteproc: qcom: Add and initialize proxy and active clocks. Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-12-22 22:50 +0100
Re: [PATCH v5 2/7] remoteproc: qcom: Add and initialize proxy and active clocks. "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org> - 2016-12-30 12:00 +0100
[PATCH v5 5/7] remoteproc: qcom: Modify clock enable and disable interface. Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> - 2016-12-15 13:30 +0100
Re: [PATCH v5 5/7] remoteproc: qcom: Modify clock enable and disable interface. Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-12-23 01:20 +0100
[PATCH v5 7/7] clk: qcom: Add GCC_MSS_RESET support Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> - 2016-12-15 13:30 +0100
Re: [PATCH v5 7/7] clk: qcom: Add GCC_MSS_RESET support Stephen Boyd <sboyd@codeaurora.org> - 2016-12-29 01:10 +0100
Re: [PATCH v5 7/7] clk: qcom: Add GCC_MSS_RESET support Andy Gross <andy.gross@linaro.org> - 2016-12-29 18:10 +0100
Re: [PATCH v5 7/7] clk: qcom: Add GCC_MSS_RESET support Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-12-29 21:00 +0100
[PATCH v5 6/7] remoteproc: qcom: Implement Hexagon core specific changes. Avaneesh Kumar Dwivedi <akdwived@codeaurora.org> - 2016-12-15 13:30 +0100
Re: [PATCH v5 6/7] remoteproc: qcom: Implement Hexagon core specific changes. Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-12-23 02:10 +0100
Re: [PATCH v5 6/7] remoteproc: qcom: Implement Hexagon core specific changes. "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org> - 2016-12-30 11:20 +0100
csiph-web