Re: [PATCH] gpio: Move freeing of GPIO hogs before numbing of the device

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: Move freeing of GPIO hogs before numbing of the device
Date	2016-12-30 09:20 +0100
Message-ID	<sU0zT-1QO-15@gated-at.bofh.it> (permalink)
References	<sQ9V7-2r7-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 19, 2016 at 6:29 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:

> When removing a gpiochip that uses GPIO hogging (e.g. by unloading the
> chip's DT overlay), a warning is printed:
>
>     gpio gpiochip8: REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED
>
> This happens because gpiochip_free_hogs() is called after the gdev->chip
> pointer is reset to NULL. Hence __gpiod_free() cannot determine the
> chip in use, and cannot clear flags nor call the optional chip-specific
> .free() callback.
>
> Move the call to gpiochip_free_hogs() up to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Patch applied to fixes and tagged for stable.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: Move freeing of GPIO hogs before numbing of the device Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-19 18:30 +0100
  Re: [PATCH] gpio: Move freeing of GPIO hogs before numbing of the device Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 09:20 +0100

csiph-web