Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1548136

RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe

Show all headers | View raw

> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@gmail.com]
> Sent: Thursday, December 29, 2016 2:43 AM
> To: Kweh, Hock Leong <hock.leong.kweh@intel.com>; David Miller
> <davem@davemloft.net>
> Cc: Joao.Pinto@synopsys.com; peppe.cavallaro@st.com;
> seraphin.bonnaffe@st.com; alexandre.torgue@gmail.com;
> manabian@gmail.com; niklas.cassel@axis.com; johan@kernel.org;
> pavel@ucw.cz; Ong, Boon Leong <boon.leong.ong@intel.com>; Voon, Weifeng
> <weifeng.voon@intel.com>; lars.persson@axis.com; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and
> stmmac_dvr_probe
> 
> On 12/27/2016 09:49 PM, Kweh, Hock Leong wrote:
> >> -----Original Message-----
> >> From: David Miller [mailto:davem@davemloft.net]
> >> Sent: Wednesday, December 28, 2016 12:34 AM
> >> To: Kweh, Hock Leong <hock.leong.kweh@intel.com>
> >> Cc: Joao.Pinto@synopsys.com; peppe.cavallaro@st.com;
> >> seraphin.bonnaffe@st.com; f.fainelli@gmail.com;
> >> alexandre.torgue@gmail.com; manabian@gmail.com;
> >> niklas.cassel@axis.com; johan@kernel.org; pavel@ucw.cz; Ong, Boon
> >> Leong <boon.leong.ong@intel.com>; Voon, Weifeng
> >> <weifeng.voon@intel.com>; lars.persson@axis.com;
> >> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize
> >> stmmac_open and stmmac_dvr_probe
> >>
> >> From: "Kweh, Hock Leong"	<hock.leong.kweh@intel.com>
> >> Date: Tue, 27 Dec 2016 22:42:36 +0800
> >>
> >>> From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
> >>
> >> You are not the author of this change, do not take credit for it.
> >>
> >> You have copied Florian's patch character by character, therefore he
> >> is the author.
> >>
> >> You also didn't CC: the netdev mailing list properly.
> >
> > Hi David & Florian,
> >
> > Just to clarify that I do not copy exactly from Florian.
> > I have changed it to have proper handling on mdio unregister while
> > netdev_register() failed as showed below:
> >
> > 	return 0;
> >
> > -error_mdio_register:
> > -	unregister_netdev(ndev);
> >  error_netdev_register:
> > +	stmmac_mdio_unregister(ndev);
> 
> Although this is required, we can't be doing it in all circumstances, we need to
> mimic what stmmac_drv_remove() does.
> 
> Let me submit an incremental fix which takes care of mdio bus unregistration.
> --
> Florian

Noted & Thanks. Will test it out once you submitted.

Thanks & Regards,
Wilson

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2016-12-27 07:40 +0100
  Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and  stmmac_dvr_probe Pavel Machek <pavel@ucw.cz> - 2016-12-27 11:50 +0100
  Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and  stmmac_dvr_probe David Miller <davem@davemloft.net> - 2016-12-27 17:50 +0100
    RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and  stmmac_dvr_probe "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2016-12-28 02:50 +0100
      [PATCH net] net: stmmac: Fix race between stmmac_drv_probe and stmmac_open Florian Fainelli <f.fainelli@gmail.com> - 2016-12-28 03:30 +0100
        Re: [PATCH net] net: stmmac: Fix race between stmmac_drv_probe and  stmmac_open David Miller <davem@davemloft.net> - 2016-12-28 03:40 +0100
      Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe Kishan Sandeep <sandeepkishan108@gmail.com> - 2016-12-28 13:00 +0100
        RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and  stmmac_dvr_probe "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2016-12-29 01:30 +0100
    RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and  stmmac_dvr_probe "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2016-12-28 06:50 +0100
      Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and  stmmac_dvr_probe Florian Fainelli <f.fainelli@gmail.com> - 2016-12-28 19:50 +0100
        RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and  stmmac_dvr_probe "Kweh, Hock Leong" <hock.leong.kweh@intel.com> - 2016-12-29 01:40 +0100
          Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and  stmmac_dvr_probe Florian Fainelli <f.fainelli@gmail.com> - 2016-12-29 01:50 +0100

csiph-web