[PATCH v6 22/25] usb: chipidea: Drop lock across event_notify during gadget stop

From	Stephen Boyd <stephen.boyd@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH v6 22/25] usb: chipidea: Drop lock across event_notify during gadget stop
Date	2016-12-29 00:00 +0100
Message-ID	<sTvmq-6sL-39@gated-at.bofh.it> (permalink)
References	<sTvmp-6sL-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The CI_HDRC_CONTROLLER_STOPPED_EVENT may want to call sleeping
APIs similar to how _gadget_stop_activity() may. Let's drop the
lock across the event so that glue drivers can make sleeping
calls.

Cc: Peter Chen <peter.chen@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
---
 drivers/usb/chipidea/udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 0db56fb7e9e9..0d532a724d48 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1793,10 +1793,10 @@ static int ci_udc_stop(struct usb_gadget *gadget)
 
 	if (ci->vbus_active) {
 		hw_device_state(ci, 0);
+		spin_unlock_irqrestore(&ci->lock, flags);
 		if (ci->platdata->notify_event)
 			ci->platdata->notify_event(ci,
 			CI_HDRC_CONTROLLER_STOPPED_EVENT);
-		spin_unlock_irqrestore(&ci->lock, flags);
 		_gadget_stop_activity(&ci->gadget);
 		spin_lock_irqsave(&ci->lock, flags);
 		pm_runtime_put(&ci->gadget.dev);
-- 
2.10.0.297.gf6727b0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 22/25] usb: chipidea: Drop lock across event_notify during gadget stop Stephen Boyd <stephen.boyd@linaro.org> - 2016-12-29 00:00 +0100
  Re: [PATCH v6 22/25] usb: chipidea: Drop lock across event_notify  during gadget stop Peter Chen <hzpeterchen@gmail.com> - 2017-01-03 07:50 +0100

csiph-web