Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1548018
| From | Luis Oliveira <Luis.Oliveira@synopsys.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module |
| Date | 2016-12-28 17:50 +0100 |
| Message-ID | <sTpAl-2m0-1@gated-at.bofh.it> (permalink) |
| References | <sTnIe-11F-7@gated-at.bofh.it> <sTnIe-11F-9@gated-at.bofh.it> <sToEh-1Kp-3@gated-at.bofh.it> <sToNX-1O0-1@gated-at.bofh.it> <sTpqF-2iH-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 28-Dec-16 16:31, Andy Shevchenko wrote:
> On Wed, 2016-12-28 at 15:53 +0000, Luis Oliveira wrote:
>> On 28-Dec-16 15:44, Andy Shevchenko wrote:
>>> On Wed, 2016-12-28 at 14:43 +0000, Luis Oliveira wrote:
>>>> - Slave mode selected in platform module (devicetree support only)
>>>> - Check for ACPI - not supported in SLAVE mode:
>>>> - Changed the ifndef style to the use of ACPI_HANDLE that
>>>> returns
>>>> NULL
>>>> if the device was not enumerated from ACPI namespace.
>>>
>>> I'm not sure what is wrong with ACPI?
>>
>> I dont have a way to test it. Just that.
>
> Okay, can you provide an excerpt to see how it will look like in DTS?
Yes, it looks like this now:
i2c@0x2000 {
compatible = "snps,designware-i2c";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x2000 0x100>;
clock-frequency = <400000>;
clocks = <&i2cclk>;
interrupts = <0>;
eeprom@64 {
compatible = "linux,slave-24c02";
reg = <0x40000064>;
};
};
>
>
>>>> - dev->functionality = I2C_FUNC_10BIT_ADDR |
>>>> DW_IC_DEFAULT_FUNCTIONALITY;
>>>> -
>>>> - i2c_dw_configure_master(pdev);
>>>> + if (ACPI_HANDLE(&pdev->dev) == NULL) {
>>>
>>> I don't think you need this at all.
>>
>> This is to avoid the use of the "ifdef" style I used before.
>
> My point is to drop it completely.
>
>>>
>>>> + device_for_each_child_node(&pdev->dev, child) {
>>>
>>> This is resource agnostic.
>>>
>>>> + fwnode_property_read_u32(child, "reg",
>>>> ®);
>>>
>>> This is as well.
>>
>> Are you suggesting I use of_ functions?
>
> Nope. See above.
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 0/7] i2c: designware: add I2C SLAVE support Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 15:50 +0100
[PATCH v5 6/7] i2c: designware: enable SLAVE in platform module Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 15:50 +0100
Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-12-28 16:50 +0100
Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 17:00 +0100
Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-12-28 17:40 +0100
Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 17:50 +0100
Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2016-12-28 18:00 +0100
Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-12-28 18:20 +0100
Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 19:20 +0100
[PATCH v5 2/7] i2c: designware: refactoring of the i2c-designware Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 15:50 +0100
Re: [PATCH v5 2/7] i2c: designware: refactoring of the i2c-designware Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-12-28 16:20 +0100
Re: [PATCH v5 2/7] i2c: designware: refactoring of the i2c-designware Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 16:40 +0100
[PATCH v5 5/7] i2c: designware: add SLAVE mode functions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 15:50 +0100
Re: [PATCH v5 5/7] i2c: designware: add SLAVE mode functions Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-12-28 16:40 +0100
Re: [PATCH v5 5/7] i2c: designware: add SLAVE mode functions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 17:10 +0100
[PATCH v5 4/7] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 15:50 +0100
Re: [PATCH v5 4/7] i2c: designware: introducing I2C_SLAVE definitions Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-12-28 16:20 +0100
[PATCH v5 1/7] i2c: designware: Cleaning and comment style fixes. Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 15:50 +0100
[PATCH v5 3/7] i2c: designware: MASTER mode as separated driver Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-28 15:50 +0100
csiph-web