Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1547967

[PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

From "Harisangam, Sharvari (S.)" <sharvari.harisangam@visteon.com>
Newsgroups linux.kernel
Subject [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode
Date 2016-12-28 15:50 +0100
Message-ID <sTnId-11F-1@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


 Corrected the condition to check if ssi is configured for AC97
 mode. Other modes like dsp_a also satisfy the ANDing condition.

Signed-off-by: Sharvari Harisangam <sharvari.harisangam@visteon.com>
---
 sound/soc/fsl/fsl_ssi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index ca6f6b1..4fbb7a2 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -317,7 +317,8 @@ MODULE_DEVICE_TABLE(of, fsl_ssi_ids);
 
 static bool fsl_ssi_is_ac97(struct fsl_ssi_private *ssi_private)
 {
-	return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97);
+	return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
+		SND_SOC_DAIFMT_AC97;
 }
 
 static bool fsl_ssi_is_i2s_master(struct fsl_ssi_private *ssi_private)
@@ -1016,7 +1017,7 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev,
 				CCSR_SSI_SCR_TCH_EN);
 	}
 
-	if (fmt & SND_SOC_DAIFMT_AC97)
+	if ((fmt & SND_SOC_DAIFMT_AC97) == SND_SOC_DAIFMT_AC97)
 		fsl_ssi_setup_ac97(ssi_private);
 
 	return 0;
-- 
2.7.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH]  ASoC : fsl_ssi : Correct the condition to check AC97 mode "Harisangam, Sharvari (S.)" <sharvari.harisangam@visteon.com> - 2016-12-28 15:50 +0100
  Re: [PATCH]  ASoC : fsl_ssi : Correct the condition to check AC97 mode Andreas Schwab <schwab@linux-m68k.org> - 2016-12-28 16:00 +0100
    Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode Timur Tabi <timur@tabi.org> - 2016-12-28 17:00 +0100
    Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode Andreas Schwab <schwab@linux-m68k.org> - 2016-12-28 18:00 +0100
    Re: [PATCH]  ASoC : fsl_ssi : Correct the condition to check AC97  mode "Harisangam, Sharvari (S.)" <sharvari.harisangam@visteon.com> - 2016-12-29 03:30 +0100
  Re: [alsa-devel] [PATCH] ASoC : fsl_ssi : Correct the condition to  check AC97 mode Fabio Estevam <festevam@gmail.com> - 2016-12-28 19:00 +0100

csiph-web