[PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations

Path	csiph.com!xmission!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations
Date	Thu, 29 Dec 2016 23:20:01 +0100
Message-ID	<sTRdf-42p-9@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=bCOI6OHF7KJy+a+D4eZ2ZIX+4UYi/iqD3O0tWpwtI64=; b=II3Srnjbl46XLZiwJtPUPwIO3MDQXZ3K58VLX793dwPO2UdN322vwahPAt2ZJiDbLl +1A3o637TYGPN8oohR4b1vubt6I0vYHUOlJpu3UV3PMJXEwoeN3wUUTBSWjbgwMhZmMU dTRbHj8W67l7y/jm2jYuOAsYeLQVsCx9DUQhbL9ZHblQYenYp3fXo4gv2D7NJjfsb7sm LCL5p+980JAiWcVILKcxxDEI0c2OlhbIjrtBqZWtJ3BuwllPbclDI47YRvl8aBJgMYoJ eNhI5w75re/8GohbA2oFz/ZgKfP/x7ve24X1qaiw9w0UFNG1UriXaMXYDS/ji+e9kUaH nOuQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=bCOI6OHF7KJy+a+D4eZ2ZIX+4UYi/iqD3O0tWpwtI64=; b=GtpvFigpPV0auk8RhcjMwDzlvuOickKTlFDUWIMqCopwC4vUAygVfwJPoSGdyJKrZm MwDxfGiCE3Xq+bSAzdlJ4WwIAt1Jxns+VTnzzfMSih9/605KIqJFyV3gDjzyDIgFvUNm iseBqUTpT6Jti1CTZQv1HWPaOfQAY8aT/+jjkY00qrr0EzRineq44jo+XLqDdmUcXS6p sCi0JAN6VtB28uSQUV8ELyeRWdN5zgQfXgFsFaAZTI16lz+ivZ6wi2VybKdpoZ0mfRII gxcRMhOjSE8cNp5BAsi2WPI3PjDFUuh1OwvWZtZP389ZUIBmWvNUxDLsgqwZa69SKCOy 7ekA==
X-Gm-Message-State	AIkVDXKaux8ZXZZR0HSIGBLCBdAlNZbUjHMuW/sgUdCGUTh07IqOZYvtT4WFVBnJ6U7Egw==
X-Received	by 10.129.88.7 with SMTP id m7mr36362610ywb.331.1483049478838; Thu, 29 Dec 2016 14:11:18 -0800 (PST)
X-Mailer	git-send-email 2.9.3
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 29 Dec 2016 17:11:12 -0500
X-Original-Message-ID	<20161229221115.31995-1-tj@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1548380

Show key headers only | View raw

Hello,

On the v2 hierarchy, when controllers are enabled and disabled, other
->*attach() callbacks of other controllers are called spuriously with
the same source and destination.  While this isn't critical, it's a
bit nasty and can lead to temporary double charging on certain
controllers.  This patchset fixes the issue.

This patchset contains the following three patches.

 0001-cgroup-cosmetic-update-to-cgroup_taskset_add.patch
 0002-cgroup-track-migration-context-in-cgroup_mgctx.patch
 0003-cgroup-call-subsys-attach-only-for-subsystems-which-.patch

0001-0002 restructures migration context tracking so that extra state
can be tracked easily.  0003 fixes the spurious ->*attach()
invocations.

This patchset is also available in the following git branch.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-avoid-identity-attach

diffstat follows.

 kernel/cgroup/cgroup-internal.h |   69 +++++++++++++++--
 kernel/cgroup/cgroup-v1.c       |   10 +-
 kernel/cgroup/cgroup.c          |  161 ++++++++++++++++------------------------
 3 files changed, 135 insertions(+), 105 deletions(-)

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCHSET for-4.11] cgroup: avoid spurious identity ->*attach() invocations Tejun Heo <tj@kernel.org> - 2016-12-29 23:20 +0100
  [PATCH 1/3] cgroup: cosmetic update to cgroup_taskset_add() Tejun Heo <tj@kernel.org> - 2016-12-29 23:20 +0100
  [PATCH 3/3] cgroup: call subsys->*attach() only for subsystems which are actually affected by migration Tejun Heo <tj@kernel.org> - 2016-12-29 23:20 +0100
  [PATCH 2/3] cgroup: track migration context in cgroup_mgctx Tejun Heo <tj@kernel.org> - 2016-12-29 23:20 +0100

csiph-web