Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup

From	Alexander Koch <mail@alexanderkoch.net>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup
Date	2016-12-29 21:40 +0100
Message-ID	<sTPEt-2W1-3@gated-at.bofh.it> (permalink)
References	<sRGlX-4lT-3@gated-at.bofh.it> <sRGlX-4lT-5@gated-at.bofh.it> <sSB0S-3Fv-7@gated-at.bofh.it> <sTNCF-1FX-5@gated-at.bofh.it> <sTOS5-2nW-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/29/2016 08:46 PM, Guenter Roeck wrote:
> On Thu, Dec 29, 2016 at 07:22:12PM +0100, Alexander Koch wrote:
>> On 12/26/2016 11:47 AM, Guenter Roeck wrote:
>>> On 12/23/2016 02:12 PM, Alexander Koch wrote:
>>>> Replace sysfs symbolic file permissions, e.g. 'S_IRUGO', by octal
>>>> permissions. This fixes checkpatch.pl warnings.
>>>>
>>>> Signed-off-by: Alexander Koch <mail@alexanderkoch.net>
>>> Please do not bother with those warnings and ignore checkpatch.
>>> We are in the process of doing an automated conversion.
>> Okay, so I shall create v3 of the patchset, without these changes. I've
>> found a typo in the 4th patch so I thought about going v3 anyways.
>>
>> I've tested operation modes 1-3 on real hardware today and found no
>> issues so far, so I hope v3 will have good chances of getting accepted.
>>
> Pretty much. One request, though: If there is no configuration data
> from DT, I would like the driver to read the mode from the chip - if for
> nothing else, this will let me test all modes, but it also supports the
> case where the chip is configured by BIOS/ROMMON.

Aye, will add this as new fourth patch then. I assume the chip reset in
adc128_init_client() clears the chip mode as well, so I will read it in
the operation mode block in adc128_probe().

Just out of interest: how does this help you test the modes? Do you
configure the chip externally and test it on a platform without
devicetree support?


Cheers,

Alex

Thread

[RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup Alexander Koch <mail@alexanderkoch.net> - 2016-12-23 23:20 +0100
  Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup Guenter Roeck <linux@roeck-us.net> - 2016-12-26 11:50 +0100
    Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup Alexander Koch <mail@alexanderkoch.net> - 2016-12-29 19:30 +0100
      Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup Guenter Roeck <linux@roeck-us.net> - 2016-12-29 20:50 +0100
        Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup Alexander Koch <mail@alexanderkoch.net> - 2016-12-29 21:40 +0100
          Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup Guenter Roeck <linux@roeck-us.net> - 2016-12-30 02:00 +0100

csiph-web