Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1548326

Re: [PATCH] mm, page_alloc: convert page_group_by_mobility_disable to static key

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 2016-12-20 at 14:43 +0100, Vlastimil Babka wrote:
> The flag is rarely enabled or even changed, so it's an ideal static
> key
> candidate. Since it's being checked in the page allocator fastpath
> via
> gfpflags_to_migratetype(), it may actually save some valuable cycles.
> 
> Here's a diff excerpt from __alloc_pages_nodemask() assembly:
> 
>         -movl    page_group_by_mobility_disabled(%rip), %ecx
> 	+.byte 0x0f,0x1f,0x44,0x00,0
>          movl    %r9d, %eax
>          shrl    $3, %eax
>          andl    $3, %eax
>         -testl   %ecx, %ecx
>         -movl    $0, %ecx
>         -cmovne  %ecx, %eax
> 
> I.e. a NOP instead of test, conditional move and some assisting
> moves.
> 
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>

Acked-by: Rik van Riel <riel@redhat.com>

-- 
All Rights Reversed.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm, page_alloc: convert page_group_by_mobility_disable to static key Vlastimil Babka <vbabka@suse.cz> - 2016-12-20 14:50 +0100
  Re: [PATCH] mm, page_alloc: convert page_group_by_mobility_disable  to static key Mel Gorman <mgorman@techsingularity.net> - 2016-12-29 13:10 +0100
  Re: [PATCH] mm, page_alloc: convert page_group_by_mobility_disable  to static key Rik van Riel <riel@redhat.com> - 2016-12-29 17:10 +0100

csiph-web