Re: [PATCH 1/4] pinctrl: dt-bindings: samsung: add drive strength macros for Exynos5433

From	Andi Shyti <andi@etezian.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] pinctrl: dt-bindings: samsung: add drive strength macros for Exynos5433
Date	2016-12-29 14:50 +0100
Message-ID	<sTJfH-7ep-3@gated-at.bofh.it> (permalink)
References	<sTEzn-4h9-7@gated-at.bofh.it> <sTEzn-4h9-9@gated-at.bofh.it> <sTEzn-4h9-5@gated-at.bofh.it> <sTHxg-673-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Krzysztof,

> >  #define EXYNOS5420_PIN_DRV_LV3		2
> >  #define EXYNOS5420_PIN_DRV_LV4		3
> >  
> > +/* Drive strengths for Exynos5433 */
> > +#define EXYNOS5433_PIN_DRV_LV1		0
> > +#define EXYNOS5433_PIN_DRV_LV2		1
> > +#define EXYNOS5433_PIN_DRV_LV3		2
> > +#define EXYNOS5433_PIN_DRV_LV4		3
> 
> Same values as existing. No need to re-define these.

Yes, I was in doubt when I prepared this patch as on one hand it
didn't look right to use EXYNOS5420_* for exynos5433, on the other
hand it didn't look right to duplicate the macros.

In anycase this values need to be fixed as Chanwoo wrote in the
other mail.

Thanks,
Andi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] pinctrl: dt-bindings: samsung: add drive strength macros  for Exynos5433 Andi Shyti <andi.shyti@samsung.com> - 2016-12-29 09:50 +0100
  Re: [PATCH 1/4] pinctrl: dt-bindings: samsung: add drive strength  macros for Exynos5433 Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-29 10:20 +0100
    Re: [PATCH 1/4] pinctrl: dt-bindings: samsung: add drive strength  macros for Exynos5433 Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-29 11:40 +0100
  Re: [1/4] pinctrl: dt-bindings: samsung: add drive strength macros for  Exynos5433 Jaehoon Chung <jh80.chung@samsung.com> - 2016-12-29 10:40 +0100
  Re: [PATCH 1/4] pinctrl: dt-bindings: samsung: add drive strength  macros for Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2016-12-29 13:00 +0100
    Re: [PATCH 1/4] pinctrl: dt-bindings: samsung: add drive strength  macros for Exynos5433 Andi Shyti <andi@etezian.org> - 2016-12-29 14:50 +0100

csiph-web