Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1548292
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] ARM64: dts: exynos5433: remove unused code |
| Date | 2016-12-29 13:00 +0100 |
| Message-ID | <sTHxg-673-11@gated-at.bofh.it> (permalink) |
| References | <sTEzn-4h9-7@gated-at.bofh.it> <sTEzn-4h9-13@gated-at.bofh.it> <sTEzn-4h9-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Dec 29, 2016 at 05:42:11PM +0900, Andi Shyti wrote: > Because the pinctrl DTS is using the samsung.h macros, the > previously pin defines are anused. Remove them. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > index 9afed9fcf7e1..3c821e5c241e 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > @@ -14,19 +14,6 @@ > > #include <dt-bindings/pinctrl/samsung.h> > > -#define PIN_PULL_NONE 0 > -#define PIN_PULL_DOWN 1 > -#define PIN_PULL_UP 3 > - > -#define PIN_DRV_LV1 0 > -#define PIN_DRV_LV2 2 > -#define PIN_DRV_LV3 1 > -#define PIN_DRV_LV4 3 > - > -#define PIN_IN 0 > -#define PIN_OUT 1 > -#define PIN_FUNC1 2 > - This should be squashed with 3/4 because logically it is strictly related to it and splitting it does not bring any benefits. Actually while looking at 3/4 I was surprised to see them not removed. Best regards, Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] Use Exynos macros for pinctrl settings Andi Shyti <andi.shyti@samsung.com> - 2016-12-29 09:50 +0100
[PATCH 4/4] ARM64: dts: exynos5433: remove unused code Andi Shyti <andi.shyti@samsung.com> - 2016-12-29 09:50 +0100
Re: [PATCH 4/4] ARM64: dts: exynos5433: remove unused code Krzysztof Kozlowski <krzk@kernel.org> - 2016-12-29 13:00 +0100
Re: [PATCH 4/4] ARM64: dts: exynos5433: remove unused code Andi Shyti <andi@smida.it> - 2016-12-29 15:00 +0100
[PATCH 2/4] ARM64: dts: exynos5433: use macros for pinctrl configuration on Exynos5433 Andi Shyti <andi.shyti@samsung.com> - 2016-12-29 09:50 +0100
csiph-web