Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1548278

Re: [RFC v2 2/3] pinctrl: imx: use radix trees for groups and functions

Show all headers | View raw

Hi Linus, All,

On Tue, Dec 27, 2016 at 11:07 PM, Linus Walleij
<linus.walleij@linaro.org> wrote:
>
> On Fri, Dec 2, 2016 at 5:35 PM, Gary Bisson
> <gary.bisson@boundarydevices.com> wrote:
>
> > This change is inspired from the pinctrl-single architecture.
> >
> > The problem with current implementation is that it isn't possible
> > to add/remove functions and/or groups dynamically. The radix tree
> > offers an easy way to do so. The intent is to offer a follow-up
> > patch later that will enable the use of pinctrl nodes in dt-overlays.
> >
> > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
>
> This patch doesn't apply on v4.10-rc1 so please rebase it
> on the mainline and resend as v3, include Fabio's review tag.

Actually it applies if the first patch of this v2 series is also applied first.
https://patchwork.kernel.org/patch/9458883/
https://patchwork.kernel.org/patch/9458889/

The 3rd patch of the series can be discarded though since it was just
an example to show the benefit of the first two.

I guess someone needs to also ack/review the first one. Because
switching to radix tree keeping the const qualifier of the driver
structure isn't really useful.

Regards,
Gary

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RFC v2 2/3] pinctrl: imx: use radix trees for groups and functions Linus Walleij <linus.walleij@linaro.org> - 2016-12-27 23:10 +0100
  Re: [RFC v2 2/3] pinctrl: imx: use radix trees for groups and functions Gary Bisson <gary.bisson@boundarydevices.com> - 2016-12-29 10:50 +0100
    Re: [RFC v2 2/3] pinctrl: imx: use radix trees for groups and functions Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 14:30 +0100

csiph-web