Re: mm: fix typo of cache_alloc_zspage()

From	Minchan Kim <minchan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: mm: fix typo of cache_alloc_zspage()
Date	2016-12-29 08:00 +0100
Message-ID	<sTCQV-3aj-1@gated-at.bofh.it> (permalink)
References	<sTykh-gM-1@gated-at.bofh.it> <sTCHf-36n-1@gated-at.bofh.it> <sTCQV-3aj-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Sergey,

On Thu, Dec 29, 2016 at 03:52:05PM +0900, Sergey Senozhatsky wrote:
> On (12/29/16 15:44), Minchan Kim wrote:
> > On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote:
> > > Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> > > ---
> > >  mm/zsmalloc.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > > index 9cc3c0b..2d6c92e 100644
> > > --- a/mm/zsmalloc.c
> > > +++ b/mm/zsmalloc.c
> > > @@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
> > >  {
> > >  	return kmem_cache_alloc(pool->zspage_cachep,
> > >  			flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
> > > -};
> > > +}
> > 
> > Although it's trivial, we need descritpion.
> > Please, could you resend to Andrew Morton with filling description?
> 
> I don't know... do we want to have it as a separate patch?
> may be we can fold it into some other patch someday later.

Xishi spent his time to make the patch(review,create/send). And I want to
give a credit to him. :)

Thanks.

Thread

mm: fix typo of cache_alloc_zspage() Xishi Qiu <qiuxishi@huawei.com> - 2016-12-29 03:10 +0100
  Re: mm: fix typo of cache_alloc_zspage() Minchan Kim <minchan@kernel.org> - 2016-12-29 07:50 +0100
    Re: mm: fix typo of cache_alloc_zspage() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-29 08:00 +0100
      Re: mm: fix typo of cache_alloc_zspage() Minchan Kim <minchan@kernel.org> - 2016-12-29 08:00 +0100
        Re: mm: fix typo of cache_alloc_zspage() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-29 08:40 +0100
          Re: mm: fix typo of cache_alloc_zspage() Minchan Kim <minchan@kernel.org> - 2016-12-29 09:00 +0100
            Re: mm: fix typo of cache_alloc_zspage() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-29 09:10 +0100
            Re: mm: fix typo of cache_alloc_zspage() Xishi Qiu <qiuxishi@huawei.com> - 2016-12-29 11:40 +0100
              Re: mm: fix typo of cache_alloc_zspage() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-30 02:10 +0100
  [PATCH V2] mm: fix typo of cache_alloc_zspage() Xishi Qiu <qiuxishi@huawei.com> - 2016-12-29 09:00 +0100

csiph-web