Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1548144

Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for a page bit

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for a page bit
Date 2016-12-29 05:20 +0100
Message-ID <sTAm5-1DN-3@gated-at.bofh.it> (permalink)
References (5 earlier) <sSY77-1nC-5@gated-at.bofh.it> <sT58C-5Ke-15@gated-at.bofh.it> <sTdzb-2MJ-5@gated-at.bofh.it> <sTrVw-49v-3@gated-at.bofh.it> <sTAcp-1zl-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Dec 28, 2016 at 8:08 PM, Nicholas Piggin <npiggin@gmail.com> wrote:
>
> Okay. The name could be a bit better though I think, for readability.
> Just a BUILD_BUG_ON if it is not constant and correct bit numbers?

I have a slightly edited patch - moved the comments around and added
some new comments (about both the sign bit, but also about how the
smp_mb() shouldn't be necessary even for the non-atomic fallback).

I also did a BUILD_BUG_ON(), except the other way around - keeping it
about the sign bit in the byte, just just verifying that yes,
PG_waiters is that sign bit.

> BTW. I just notice in your patch too that you didn't use "nr" in the
> generic version.

And I fixed that too.

Of course, I didn't test the changes (apart from building it). But
I've been running the previous version since yesterday, so far no
issues.

                Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for a page bit Nicholas Piggin <npiggin@gmail.com> - 2016-12-25 04:10 +0100
  Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-25 23:00 +0100
    Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting  for a page bit Nicholas Piggin <npiggin@gmail.com> - 2016-12-26 02:20 +0100
      Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-26 20:10 +0100
        Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting  for a page bit Nicholas Piggin <npiggin@gmail.com> - 2016-12-27 12:30 +0100
          Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-27 20:00 +0100
            Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-27 20:40 +0100
              Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-27 20:50 +0100
                Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-27 21:20 +0100
            Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-27 20:40 +0100
            Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting  for a page bit Nicholas Piggin <npiggin@gmail.com> - 2016-12-28 05:00 +0100
              Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting  for a page bit Nicholas Piggin <npiggin@gmail.com> - 2016-12-29 05:10 +0100
                Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-29 05:20 +0100
                Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting  for a page bit Nicholas Piggin <npiggin@gmail.com> - 2016-12-29 06:30 +0100
                Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Mel Gorman <mgorman@techsingularity.net> - 2017-01-03 11:30 +0100
                Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting  for a page bit Nicholas Piggin <npiggin@gmail.com> - 2017-01-03 13:40 +0100
                Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Mel Gorman <mgorman@techsingularity.net> - 2017-01-03 18:20 +0100
                [PATCH] mm/filemap: fix parameters to test_bit() Olof Johansson <olof@lixom.net> - 2016-12-29 23:20 +0100
              Re: [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for  a page bit Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-28 20:20 +0100

csiph-web