Re: [PATCH 1/1] Coccinelle: memdup: fix the report mode

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] Coccinelle: memdup: fix the report mode
Date	Tue, 27 Dec 2016 18:50:01 +0100
Message-ID	<sT42R-56S-3@gated-at.bofh.it> (permalink)
References	<sT42R-56S-5@gated-at.bofh.it>
X-Ironport-Av	E=Sophos;i="5.33,417,1477954800"; d="scan'208";a="206169779"
X-X-Sender	jll@hadrien
User-Agent	Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
X-Original-Cc	Gilles Muller <Gilles.Muller@lip6.fr>, Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 27 Dec 2016 18:43:48 +0100 (CET)
X-Original-Message-ID	<alpine.DEB.2.20.1612271843240.2001@hadrien>
X-Original-References	<20161227173940.8327-1-nicolas.iooss_linux@m4x.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1547708

Show key headers only | View raw


On Tue, 27 Dec 2016, Nicolas Iooss wrote:

> The pattern which was used in report mode included an annoying kmemdup
> call, which has no chance of being there. Remove this stray line.
>
> While at it, the name of function kmemdup was misspelled in the warning
> message. Fix this.
>
> Fixes: 29a36d4dec6c ("scripts/coccinelle: improve the coverage of some
> semantic patches")
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Thanks for the fixes.

julia

> ---
>  scripts/coccinelle/api/memdup.cocci | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/coccinelle/api/memdup.cocci b/scripts/coccinelle/api/memdup.cocci
> index 3d1aa71b7579..8fd6437beda8 100644
> --- a/scripts/coccinelle/api/memdup.cocci
> +++ b/scripts/coccinelle/api/memdup.cocci
> @@ -49,7 +49,6 @@ statement S;
>  @@
>
>  *  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
> -   to = kmemdup(from,size,flag);
>     if (to==NULL || ...) S
>  *  memcpy(to, from, size);
>
> @@ -57,10 +56,10 @@ statement S;
>  p << r.p;
>  @@
>
> -coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdep")
> +coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdup")
>
>  @script:python depends on report@
>  p << r.p;
>  @@
>
> -coccilib.report.print_report(p[0], "WARNING opportunity for kmemdep")
> +coccilib.report.print_report(p[0], "WARNING opportunity for kmemdup")
> --
> 2.11.0
>
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] Coccinelle: memdup: fix the report mode Julia Lawall <julia.lawall@lip6.fr> - 2016-12-27 18:50 +0100

csiph-web