[PATCH v1 09/54] block: comment on bio_iov_iter_get_pages()

From	Ming Lei <tom.leiming@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v1 09/54] block: comment on bio_iov_iter_get_pages()
Date	2016-12-27 17:10 +0100
Message-ID	<sT2u6-4eA-29@gated-at.bofh.it> (permalink)
References	<sT2u5-4eA-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

bio_iov_iter_get_pages() used unused bvec spaces for
storing page pointer array temporarily, and this patch
comments on this usage wrt. multipage bvec support.

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 block/bio.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/block/bio.c b/block/bio.c
index d4a1e0b63ea0..10398969353b 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -859,6 +859,10 @@ EXPORT_SYMBOL(bio_add_page);
  *
  * Pins as many pages from *iter and appends them to @bio's bvec array. The
  * pages will have to be released using put_page() when done.
+ *
+ * The hacking way of using bvec table as page pointer array is safe
+ * even after multipage bvec is introduced because that space can be
+ * thought as unused by bio_add_page().
  */
 int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter)
 {
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v1 09/54] block: comment on bio_iov_iter_get_pages() Ming Lei <tom.leiming@gmail.com> - 2016-12-27 17:10 +0100

csiph-web