Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1547276

Re: [RFC PATCH 4.10 0/6] Switch BPF's digest to SHA256

From Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 4.10 0/6] Switch BPF's digest to SHA256
Date 2016-12-26 09:30 +0100
Message-ID <sSyPn-2hM-1@gated-at.bofh.it> (permalink)
References <sRKfT-7Ww-3@gated-at.bofh.it>
Organization Core

Show all headers | View raw


Andy Lutomirski <luto@kernel.org> wrote:
> Since there are plenty of uses for the new-in-4.10 BPF digest feature
> that would be problematic if malicious users could produce collisions,
> the BPF digest should be collision-resistant.  SHA-1 is no longer
> considered collision-resistant, so switch it to SHA-256.
> 
> The actual switchover is trivial.  Most of this series consists of
> cleanups to the SHA256 code to make it usable as a standalone library
> (since BPF should not depend on crypto).
> 
> The cleaned up library is much more user-friendly than the SHA-1 code,
> so this also significantly tidies up the BPF digest code.
> 
> This is intended for 4.10.  If this series misses 4.10 and nothing
> takes its place, then we'll have an unpleasant ABI stability
> situation.

Can you please explain why BPF needs to be able to use SHA directly
rather than through the crypto API?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[RFC PATCH 4.10 0/6] Switch BPF's digest to SHA256 Andy Lutomirski <luto@kernel.org> - 2016-12-24 03:30 +0100
  Re: [RFC PATCH 4.10 0/6] Switch BPF's digest to SHA256 Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-26 09:30 +0100

csiph-web